Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Template out the message #52

Merged

Conversation

@ericdill
Copy link
Contributor

ericdill commented May 23, 2017

Need to template the message when returning it.

Need to template the message when returning it.
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 23, 2017

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files           2        2           
  Lines         248      248           
=======================================
  Hits          239      239           
  Misses          9        9
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 96.32% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399f580...ddbd97e. Read the comment docs.

Copy link
Collaborator

parente left a comment

Totally missed what was wrong here until @ericdill explained it. Oy.

@parente parente merged commit 897f2eb into Valassis-Digital-Media:master May 23, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 96.37%)
Details
codecov/project 96.37% (+0%) compared to 399f580
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericdill ericdill deleted the ericdill:template-remove-message branch May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.