Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Rerun changelog generator #54

Merged

Conversation

@ericdill
Copy link
Contributor

ericdill commented May 23, 2017

Amazingly good catch @jakirkham (this might sound sarcastic, but it truly is a sincere "amazingly")

@@ -1,8 +1,7 @@
# Change Log

## [0.7.2](https://github.com/maxpoint/conda-mirror/tree/0.7.2) (2017-05-23)

This comment has been minimized.

Copy link
@jakirkham

jakirkham May 23, 2017

Contributor

Do you still want this blank line? Not sure how you like to do formatting here. So this is merely a question.

This comment has been minimized.

Copy link
@ericdill

ericdill May 23, 2017

Author Contributor

Do you still want this blank line?

The automated changelog generator removed it, so 🤷‍♂️

Not sure how you like to do formatting here.

I like to do none of the formatting and let the generator handle it 😀

This comment has been minimized.

Copy link
@jakirkham

jakirkham May 23, 2017

Contributor

Yeah, it seems to do it everywhere else and looks fine there. So seems fine. 😄

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 23, 2017

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files           2        2           
  Lines         237      237           
=======================================
  Hits          229      229           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca89ce...30e1fa1. Read the comment docs.

@jakirkham

This comment has been minimized.

Copy link
Contributor

jakirkham commented May 23, 2017

np. Glad to help. 😄

@jakirkham

This comment has been minimized.

Copy link
Contributor

jakirkham commented May 23, 2017

LGTM

@ericdill ericdill merged commit a5601f0 into Valassis-Digital-Media:master May 23, 2017
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 5ca89ce...30e1fa1
Details
codecov/project 96.62% remains the same compared to 5ca89ce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented May 23, 2017

Thanks for the 👀 @jakirkham

@ericdill ericdill deleted the ericdill:rerun-changelog-generator branch May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.