Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EOFError when reading tar files. #58

Merged
merged 1 commit into from Aug 7, 2017

Conversation

@dmkent
Copy link
Contributor

dmkent commented Aug 7, 2017

Deal with exception from tar file.

Relates issue #57.

Closes #57.
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Aug 7, 2017

Hello @dmkent! Thanks for submitting the PR.

Line 430:80: E501 line too long (81 > 79 characters)
Line 529:80: E501 line too long (81 > 79 characters)
Line 530:80: E501 line too long (91 > 79 characters)
Line 615:80: E501 line too long (91 > 79 characters)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 7, 2017

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files           2        2           
  Lines         237      237           
=======================================
  Hits          229      229           
  Misses          8        8
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 96.58% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5601f0...26b6013. Read the comment docs.

@ericdill

This comment has been minimized.

Copy link
Contributor

ericdill commented Aug 7, 2017

Ultimately the same issue as #56 . Thanks for the PR @dmkent !

Closes #56
Closes #57

@ericdill ericdill merged commit 12d0f43 into Valassis-Digital-Media:master Aug 7, 2017
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 0% of diff hit (target 96.62%)
Details
codecov/project 96.62% remains the same compared to a5601f0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericdill ericdill mentioned this pull request Aug 7, 2017
@ericdill

This comment has been minimized.

Copy link
Contributor

ericdill commented Aug 7, 2017

@dmkent the 0.7.3 release (with your bugfix) is available on pypi (pip install --upgrade conda-mirror) and will be available via conda-forge soon-ish (conda-forge/conda-mirror-feedstock#3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.