Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: First pass at dry-run #59

Merged
merged 6 commits into from Sep 19, 2017

Conversation

@ericdill
Copy link
Contributor

ericdill commented Sep 18, 2017

Pretty simple addition: --dry-run. This exits after figuring out what local packages are blacklisted and need to be removed.

Closes #39

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Sep 18, 2017

Hello @ericdill! Thanks for updating the PR.

Line 178:80: E501 line too long (80 > 79 characters)
Line 448:80: E501 line too long (81 > 79 characters)
Line 551:80: E501 line too long (81 > 79 characters)
Line 552:80: E501 line too long (91 > 79 characters)
Line 645:80: E501 line too long (89 > 79 characters)
Line 658:80: E501 line too long (95 > 79 characters)

Line 134:80: E501 line too long (85 > 79 characters)
Line 145:80: E501 line too long (97 > 79 characters)
Line 146:80: E501 line too long (82 > 79 characters)
Line 147:80: E501 line too long (84 > 79 characters)
Line 159:80: E501 line too long (86 > 79 characters)
Line 160:80: E501 line too long (81 > 79 characters)
Line 161:80: E501 line too long (82 > 79 characters)
Line 162:80: E501 line too long (84 > 79 characters)
Line 177:80: E501 line too long (98 > 79 characters)

Comment last updated on September 19, 2017 at 11:29 Hours UTC
@ericdill ericdill requested a review from parente Sep 18, 2017
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 18, 2017

Codecov Report

Merging #59 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   96.62%   96.88%   +0.26%     
==========================================
  Files           2        2              
  Lines         237      257      +20     
==========================================
+ Hits          229      249      +20     
  Misses          8        8
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 96.85% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7bda1...e37d364. Read the comment docs.

info = resp.get('info', {})
packages = resp.get('packages', {})
# Patch the repodata.json so that all package info dicts contain a "subdir" key.
# Apparently some channels on anaconda.org do not contain the 'subdir' field. I

This comment has been minimized.

Copy link
@parente

parente Sep 18, 2017

Collaborator

Missing word: think

@parente parente self-requested a review Sep 18, 2017
@parente

This comment has been minimized.

Copy link
Collaborator

parente commented Sep 18, 2017

Other than the one very minor nit, it looks fine. :shipit:

@ericdill

This comment has been minimized.

Copy link
Contributor Author

ericdill commented Sep 19, 2017

Thanks @parente

@ericdill ericdill merged commit 6dadd67 into master Sep 19, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ericdill ericdill deleted the add-dry-run branch Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.