Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add license checks #7

Merged
merged 3 commits into from Nov 2, 2016

Conversation

@ericdill
Copy link
Contributor

ericdill commented Nov 2, 2016

This adds checks to avoid mirroring agpl or unlicensed conda packages
internally. cc @parente @mariusvniekerk

ericdill added 2 commits Nov 2, 2016
upstream_package_names = list(upstream_repo_metadata.keys())
local_package_names = list(local_repo_metadata.keys())
for pkg in upstream_package_names:
if pkg not in local_package_names:

This comment has been minimized.

Copy link
@mariusvniekerk

mariusvniekerk Nov 2, 2016

Collaborator

Repeated linear search here, this could get ugly for the initial mirror

This comment has been minimized.

Copy link
@ericdill

ericdill Nov 2, 2016

Author Contributor

fair point

This comment has been minimized.

Copy link
@ericdill

ericdill Nov 2, 2016

Author Contributor

updated

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 2, 2016

Current coverage is 92.85% (diff: 100%)

Merging #7 into master will increase coverage by 1.94%

@@             master         #7   diff @@
==========================================
  Files             2          2          
  Lines            77         98    +21   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             70         91    +21   
  Misses            7          7          
  Partials          0          0          

Powered by Codecov. Last update 7fe5590...2a2ad2f

@mariusvniekerk

This comment has been minimized.

Copy link
Collaborator

mariusvniekerk commented Nov 2, 2016

LGTM

@ericdill ericdill merged commit 70fd1b3 into master Nov 2, 2016
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 90.90%)
Details
codecov/project 92.85% (+1.94%) compared to 7fe5590
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ericdill ericdill deleted the check-licenses branch Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.