Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda_mirror.py: added command line swith: --no-validate-target #72

Merged
merged 1 commit into from Sep 27, 2018

Conversation

@magnuhho
Copy link
Contributor

magnuhho commented Sep 24, 2018

By default conda-mirror will validate every file that is found within the target folder.
This process may take hours.
The files are also validated on download, so unless there is file system damage, files in the target folder should be okay.

This change gives an optional command-line argument giving the user the ability to bypass the target folder validation, speeding up the process.

This significantly reduces runtime for initial sync where you may have to run conda-mirror several times before all data is downloaded, depending on speed and stability of your network connection.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #72 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   96.88%   96.89%   +0.01%     
==========================================
  Files           2        2              
  Lines         257      258       +1     
==========================================
+ Hits          249      250       +1     
  Misses          8        8
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 96.86% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f92926...89c17aa. Read the comment docs.

@parente parente closed this Sep 25, 2018
@parente parente reopened this Sep 25, 2018
@parente

This comment has been minimized.

Copy link
Collaborator

parente commented Sep 27, 2018

LGTM. Thanks! 🍰

@parente parente merged commit 4388f35 into Valassis-Digital-Media:master Sep 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.