Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda_mirror.py: corrected numbering in output when validating #75

Merged
merged 1 commit into from Oct 18, 2018

Conversation

@magnuhho
Copy link
Contributor

magnuhho commented Oct 16, 2018

When validating packages 'num' of 'count' is logged as the progress indicator.
Num being the position of the package in a zero based list gives the output: "Validating 0 of 5" packages, stopping av "4 of 5".
This fix adds +1 to num so the first of five packages gives "1 of 5" and the validation process ends with 5 of 5 packages.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 16, 2018

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files           2        2           
  Lines         258      258           
=======================================
  Hits          245      245           
  Misses         13       13
Impacted Files Coverage Δ
conda_mirror/conda_mirror.py 94.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaaeaf8...a2d95e1. Read the comment docs.

@parente

This comment has been minimized.

Copy link
Collaborator

parente commented Oct 18, 2018

👍

@parente parente merged commit 96bad91 into Valassis-Digital-Media:master Oct 18, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@magnuhho magnuhho deleted the magnuhho:numbering branch Oct 25, 2018
magnuhho added a commit to magnuhho/conda-mirror that referenced this pull request Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.