From 7a357a23ebe38b58b63f134142468abe2f88c975 Mon Sep 17 00:00:00 2001 From: Eduard Valeyev Date: Thu, 30 Jun 2022 16:54:26 -0400 Subject: [PATCH 1/2] reduce compile noise of {blas,lapack}pp due to addition of (command-line) compile defintions for BLAS_FORTRAN_ADD_ and LAPACK_FORTRAN_ADD_ ... not sure why these were needed in the first place --- cmake/modules/FindOrFetchBTAS.cmake | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmake/modules/FindOrFetchBTAS.cmake b/cmake/modules/FindOrFetchBTAS.cmake index 775d1964b6..888534b283 100644 --- a/cmake/modules/FindOrFetchBTAS.cmake +++ b/cmake/modules/FindOrFetchBTAS.cmake @@ -57,8 +57,9 @@ if (NOT TARGET BTAS::BTAS) if (NOT LINALG_MANGLING STREQUAL lower_) message(WARNING "Linear algebra libraries' mangling convention not specified; specify -DLINALG_MANGLING={lower,lower_,UPPER}, if needed; will assume lower_") endif(NOT LINALG_MANGLING STREQUAL lower_) - target_compile_definitions(blaspp PUBLIC -DBLAS_FORTRAN_ADD_=1) - target_compile_definitions(lapackpp PUBLIC -DLAPACK_FORTRAN_ADD_=1) + # these were needed for some configs at some point in the past? But in most cases they just produce compile noise +# target_compile_definitions(blaspp PUBLIC -DBLAS_FORTRAN_ADD_=1) +# target_compile_definitions(lapackpp PUBLIC -DLAPACK_FORTRAN_ADD_=1) endif() endif (_linalgpp_use_standard_linalg_kits) From bde0b655431ac421a190f20e51b70a93738e5a07 Mon Sep 17 00:00:00 2001 From: Eduard Valeyev Date: Thu, 30 Jun 2022 16:54:33 -0400 Subject: [PATCH 2/2] misc fixups --- cmake/modules/FindOrFetchBTAS.cmake | 2 +- doc/dox/dev/Customizing-Arrays.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/modules/FindOrFetchBTAS.cmake b/cmake/modules/FindOrFetchBTAS.cmake index 888534b283..57a4b94ac0 100644 --- a/cmake/modules/FindOrFetchBTAS.cmake +++ b/cmake/modules/FindOrFetchBTAS.cmake @@ -55,7 +55,7 @@ if (NOT TARGET BTAS::BTAS) target_compile_definitions(lapackpp PUBLIC -DLAPACK_FORTRAN_UPPER=1) else() if (NOT LINALG_MANGLING STREQUAL lower_) - message(WARNING "Linear algebra libraries' mangling convention not specified; specify -DLINALG_MANGLING={lower,lower_,UPPER}, if needed; will assume lower_") + message(WARNING "Linear algebra libraries' mangling convention not specified; specify -DLINALG_MANGLING={lower,lower_,UPPER}, if needed; BLASPP will try to autodetect") endif(NOT LINALG_MANGLING STREQUAL lower_) # these were needed for some configs at some point in the past? But in most cases they just produce compile noise # target_compile_definitions(blaspp PUBLIC -DBLAS_FORTRAN_ADD_=1) diff --git a/doc/dox/dev/Customizing-Arrays.md b/doc/dox/dev/Customizing-Arrays.md index 7f06690be2..ef28b67972 100644 --- a/doc/dox/dev/Customizing-Arrays.md +++ b/doc/dox/dev/Customizing-Arrays.md @@ -424,7 +424,7 @@ public: // MADNESS compliant serialization template - void serialize(const Archive&); + void serialize(Archive&); }; // class MyLazyTile ```