Permalink
Commits on Dec 1, 2016
  1. Auto merge of #2456 - micbou:remove-outdated-syntastic-option, r=Vall…

    …oric
    
    [READY] Remove outdated Syntastic option
    
    The `ycm_register_as_syntastic_checker` option was introduced a long time ago in commit 16b6f87 and became obsolete when [Syntastic support was replaced](6c01881). Since then, it doesn't serve any purpose except being an alias to the `ycm_show_diagnostics_ui` option which can be an issue (see #2455) so we remove it.
    
    Fixes #2455.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2456)
    <!-- Reviewable:end -->
    homu committed Dec 1, 2016
  2. Remove outdated Syntastic option

    micbou committed Dec 1, 2016
Commits on Nov 27, 2016
  1. Auto merge of #2430 - micbou:client-logfile, r=Valloric

    [READY] Add client logfile
    
    We have a lot of issue reports with Python exceptions that interrupt user workflow or even worse make the editor unusable and force users to restart it (e.g. issue #2192). We really want to avoid that but at the same time we can't just silence these exceptions because they are useful to debug the issue. Logging them to Vim `:messages` is not practical because we can't write to it without displaying messages in the status line which, in addition to distract users, may lead to various issues like the infamous `Press ENTER or type command to continue` message. This is why a logfile is needed.
    
    For now, only server crashes are logged but more logging will be added: connection issues with the server (`ConnectTimeout`, `ReadTimeout`, etc. exceptions), UltiSnips unavailability, requests sent to the server, etc.
    
    The behavior of the `:YcmToggleLogs` command is changed to accept multiple arguments where each argument is a logfile name. Each of these files is opened in a separate window or closed if already open. When no argument is given, the list of available logfiles is displayed to the user. Example:
    ```
    Available logfiles are:
    ycm_pz83u7.log
    ycmd_23830_stderr_gf6j3i.log
    ycmd_23830_stdout_gmpa_k.log
    ```
    
    With this change and PR #2342, we will add the completers logfiles to the list of files that can be opened with the `:YcmToggleLogs` command.
    
    A bunch of tests are added that cover almost all changes introduced by this PR.
    
    <!-- Reviewable:start -->
    
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2430)
    <!-- Reviewable:end -->
    homu committed Nov 27, 2016
Commits on Nov 22, 2016
  1. Auto merge of #2445 - micbou:documentation-clang-3.9, r=puremourning

    [READY] Bump Clang version in documentation
    
    Since PR Valloric/ycmd#590, Clang 3.9 is required because of the `KeepGoing` option. In fact, it is still possible to successfully compile against a 3.8 system libclang or with the `-DEXTERNAL_LIBCLANG_PATH` flag pointing to a 3.8 libclang since [the headers included in ycmd](https://github.com/Valloric/ycmd/tree/master/cpp/llvm/include/clang-c) are used in these two cases. However, the `KeepGoing` option will have no effect. So, we still recommend Clang 3.9 in all cases.
    
    Closes Valloric/ycmd#654.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2445)
    <!-- Reviewable:end -->
    homu committed Nov 22, 2016
  2. Bump Clang version in documentation

    micbou committed Nov 5, 2016
Commits on Nov 19, 2016
  1. Add client logfile

    micbou committed May 6, 2016
Commits on Nov 15, 2016
  1. Auto merge of #2441 - micbou:flake8, r=Valloric

    [READY] Fix flake8 error
    
    This fixes a new error detected by the last version of `pycodestyle` (2.2.0), which is a dependency of `flake8`:
    ```
    C:\projects\youcompleteme\python\ycm\youcompleteme.py:69:1: E305 expected 2 blank lines after class or function definition, found 1
    ```
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2441)
    <!-- Reviewable:end -->
    homu committed Nov 15, 2016
  2. Fix flake8 error

    micbou committed Nov 15, 2016
Commits on Nov 14, 2016
  1. Auto merge of #2436 - dojoteef:reuse_preview_buffer, r=micbou

    Address #1366 by reusing a single preview buffer
    
    * Additionally set the preview buffer to be unlisted so it does not interfere with commands like :bnext
    * See [my comment](#1366 (comment)) for more details
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2436)
    <!-- Reviewable:end -->
    homu committed Nov 14, 2016
Commits on Nov 11, 2016
  1. Fix another test failure

    * Because I cannot seem to run the tests locally I am relying on the CI
    tests which kind of sucks...
    dojoteef committed Nov 11, 2016
  2. Doh, forgot to revert my previous changes. Fixed!

    dojoteef committed Nov 11, 2016
  3. Addressed review comments and fixed tests

    dojoteef committed Nov 11, 2016
  4. Address #1366 by reusing a single preview buffer

    * Additionally set the preview buffer to be unlisted so it does not
    interfere with commands like :bnext
    dojoteef committed Nov 11, 2016
  5. Auto merge of #2434 - bstaletic:omnifunc, r=micbou

    Don't set omnifunc when not allowed
    
    # PR Prelude
    
    Thank you for working on YCM! :)
    
    **Please complete these steps and check these boxes (by putting an `x` inside
    the brackets) _before_ filing your PR:**
    
    - [x] I have read and understood YCM's [CONTRIBUTING][cont] document.
    - [x] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
    - [x] I have included tests for the changes in my PR. If not, I have included a
      rationale for why I haven't.
    - [x] **I understand my PR may be closed if it becomes obvious I didn't
      actually perform all of these steps.**
    
    # Why this change is necessary and useful
    
    [Please explain **in detail** why the changes in this PR are needed.]
    
    See pull request: [#2072](#2072)
    Unfortunately I was not able to reproduce the original author's results. I tried using a clean .vim and .vimrc. The only plugins I used were YCM and ctrlfs.vim, just as the original author mentioned. The .vimrc looks like this:
    ```VimL
    syntax on
    set history=500
    set nocp
    filetype plugin indent on
    set encoding=GBK
    ```
    Whatever I tried to do with configuration, I couldn't get a start without an error, but it is already known that YCM doesn't work properly with any file not using UTF encoding.
    The error I was getting on vim start up:
    ```
    Error detected while processing function youcompleteme#Enable[67]..<SNR>36_OnBufferRead[6]..<SNR>36_AllowedToCompleteInCurrentBuffer[1]..<SNR>36_AllowedToCompleteInBuffer:
    line   15:
    E715: Dictionary required
    Press ENTER or type command to continue
    Error detected while processing function <SNR>36_OnCursorMovedNormalMode[1]..<SNR>36_AllowedToCompleteInCurrentBuffer[1]..<SNR>36_AllowedToCompleteInBuffer:
    line   15:
    E715: Dictionary required
    Press ENTER or type command to continue
    ```
    Error I was having after almost every key press:
    ```
    Error detected while processing function <SNR>36_OnCursorMovedNormalMode[1]..<SNR>36_AllowedToCompleteInCurrentBuffer[1]..<SNR>36_AllowedToCompleteInBuffer:
    line   15:
    E715: Dictionary required
    Press ENTER or type command to continue
    ```
    
    [cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
    [code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md
    
    <!-- Reviewable:start -->
    
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2434)
    <!-- Reviewable:end -->
    homu committed Nov 11, 2016
Commits on Nov 10, 2016
  1. Fromating and function rename

    bstaletic committed Nov 10, 2016
Commits on Nov 9, 2016
  1. Don't set omnifunc when not allowed

    bstaletic committed Nov 9, 2016
Commits on Nov 3, 2016
  1. Auto merge of #2425 - dhleong:dhleong/fix-namespace-insert, r=Valloric

    Fix InsertNamespace
    
    # PR Prelude
    
    Thank you for working on YCM! :)
    
    **Please complete these steps and check these boxes (by putting an `x` inside
    the brackets) _before_ filing your PR:**
    
    - [x] I have read and understood YCM's [CONTRIBUTING][cont] document.
    - [x] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
    - [x] I have included tests for the changes in my PR. If not, I have included a
      rationale for why I haven't.
    - [x] **I understand my PR may be closed if it becomes obvious I didn't
      actually perform all of these steps.**
    
    # Why this change is necessary and useful
    
    Auto-inserting namespace imports in C# is broken because the `ReplaceChunk()` call is missing an argument
    
    [cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
    [code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md
    
    ReplaceChunk must have changed to require the buffer at some point
    
    No test is included because it's a one-line change; the method is theoretically covered, so I'm not sure why the missing argument error was not caught (not familiar with these tests). Happy to add one if needed (and I can get pointed in the right direction).
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2425)
    <!-- Reviewable:end -->
    homu committed Nov 3, 2016
  2. Rename argument

    dhleong committed Nov 3, 2016
  3. Cleanup

    dhleong committed Nov 3, 2016
Commits on Nov 2, 2016
  1. Fix InsertNamespace indent matching

    Aso updates the appropriate tests and adds docs to some
    relevant methods whose behavior might be confusing
    dhleong committed Nov 2, 2016
Commits on Nov 1, 2016
  1. Auto merge of #2423 - micbou:gitter, r=micbou

    [READY] Add Gitter badge and encourage users to ask questions on Gitter
    
    This may help reduce the number of issues opened for questions or misconfigurations. This is also an alternative to the Google group for users that can't access it because of country regulations.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2423)
    <!-- Reviewable:end -->
    homu committed Nov 1, 2016
  2. Add some tests for InsertNamespace

    dhleong committed Nov 1, 2016
Commits on Oct 31, 2016
  1. Fix InsertNamespace

    ReplaceChunk must have changed to require the buffer at some point
    dhleong committed Oct 31, 2016
  2. Add Gitter badge

    micbou committed Oct 31, 2016
Commits on Oct 28, 2016
  1. Auto merge of #2396 - dpzmick:patch-1, r=micbou

    Update README.md
    
    # PR Prelude
    
    Thank you for working on YCM! :)
    
    **Please complete these steps and check these boxes (by putting an `x` inside
    the brackets) _before_ filing your PR:**
    
    - [x] I have read and understood YCM's [CONTRIBUTING][cont] document.
    - [x] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
    - [x] I have included tests for the changes in my PR. If not, I have included a
      rationale for why I haven't.
    - [x] **I understand my PR may be closed if it becomes obvious I didn't
      actually perform all of these steps.**
    
    [cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
    [code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md
    
    # Why this change is necessary and useful
    ycmd has this support: Valloric/ycmd#628
    
    no tests needed, only a change to docs
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2396)
    <!-- Reviewable:end -->
    homu committed Oct 28, 2016
  2. Auto merge of #2412 - micbou:appveyor-coverage, r=Valloric

    [READY] Enable coverage on AppVeyor
    
    I forgot to do that when adding coverage.
    
    Also, the `cover` folder is created at the project root, not in the `python` folder.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2412)
    <!-- Reviewable:end -->
    homu committed Oct 28, 2016
  3. Update README.md

    dpzmick committed Oct 20, 2016
Commits on Oct 27, 2016
  1. Ignore cover folder

    micbou committed Oct 27, 2016
  2. Enable coverage on AppVeyor

    micbou committed Oct 27, 2016
  3. Auto merge of #2407 - micbou:remove-unloaded-buffer-parameter, r=vheon

    [READY] Remove unloaded_buffer parameter
    
    See PR Valloric/ycmd#542.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2407)
    <!-- Reviewable:end -->
    homu committed Oct 27, 2016
Commits on Oct 26, 2016
  1. Remove unloaded_buffer parameter

    micbou committed Oct 25, 2016
Commits on Oct 25, 2016
  1. Auto merge of #2394 - micbou:move-client-tests, r=Valloric

    [READY] Move client tests to the main tests folder
    
    This makes it possible to configure all tests at a package level by implementing the `setUpPackage` and `tearDownPackage` functions in `python/ycm/tests/__init__.py` file.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2394)
    <!-- Reviewable:end -->
    homu committed Oct 25, 2016
  2. Auto merge of #2405 - micbou:called-process-error, r=Valloric

    [READY] Catch CalledProcessError exception in install script
    
    See PR Valloric/ycmd#630.
    
    Closes #2351.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2405)
    <!-- Reviewable:end -->
    homu committed Oct 25, 2016
  3. Auto merge of #2406 - micbou:shutdown-request, r=Valloric

    [READY] Remove unused code in shutdown request
    
    This is what happens when you copy paste code.
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2406)
    <!-- Reviewable:end -->
    homu committed Oct 25, 2016
  4. Remove unused code in shutdown request

    micbou committed Oct 25, 2016