[READY] Disable flake8 for Python 2.6 on Travis #2279

Merged
merged 1 commit into from Aug 18, 2016

Projects

None yet

4 participants

@micbou
Collaborator
micbou commented Aug 10, 2016 edited

See Valloric/ycmd#570.


This change is Reviewable

@Valloric
Owner

LGTM (Reviewable is currently down).

@Valloric Valloric commented on the diff Aug 10, 2016
.travis.yml
env:
matrix:
- - YCM_PYTHON_VERSION=2.7
- - YCM_PYTHON_VERSION=2.6
- - YCM_PYTHON_VERSION=3.3
+ - YCM_PYTHON_VERSION=2.7 YCM_FLAKE8=true
@Valloric
Valloric Aug 10, 2016 Owner

Needs comment.

@micbou
Collaborator
micbou commented Aug 10, 2016

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


.travis.yml, line 15 [r1] (raw file):

Previously, Valloric (Val Markovic) wrote…

Needs comment.

Done.

Comments from Reviewable

@micbou micbou changed the title from [RFC] Disable flake8 for Python 2.6 on Travis to [READY] Disable flake8 for Python 2.6 on Travis Aug 10, 2016
@micbou micbou Disable flake8 for Python 2.6 on Travis
Since version 3.0.0, flake8 does not support Python 2.6, 3.2 and 3.3
anymore. It is still working for our Python 3.3 runs on Travis but
not for the Python 2.6 one so we only disable it for this version.
eace44f
@vheon
Collaborator
vheon commented Aug 18, 2016

:lgtm: @homu r=Valloric


Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@homu
Collaborator
homu commented Aug 18, 2016

📌 Commit eace44f has been approved by Valloric

@homu
Collaborator
homu commented Aug 18, 2016

⚡️ Test exempted - status

@homu homu merged commit eace44f into Valloric:master Aug 18, 2016

3 of 4 checks passed

code-review/reviewable Review in progress: 1 of 2 LGTMs obtained
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test exempted
Details
@homu homu added a commit that referenced this pull request Aug 18, 2016
@homu homu Auto merge of #2279 - micbou:flake8, r=Valloric
[READY] Disable flake8 for Python 2.6 on Travis

See Valloric/ycmd#570.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2279)
<!-- Reviewable:end -->
80ae455
@micbou micbou deleted the micbou:flake8 branch Aug 18, 2016
@homu homu added a commit that referenced this pull request Aug 18, 2016
@homu homu Auto merge of #2290 - micbou:update-ycmd, r=vheon
[READY] Update to latest ycmd

PR #2279 needs to be merged before this one.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2290)
<!-- Reviewable:end -->
b94fcb2
@micbou micbou added a commit to micbou/YouCompleteMe that referenced this pull request Dec 6, 2016
@micbou micbou Revert PR #2279 3d31999
@micbou micbou added a commit to micbou/YouCompleteMe that referenced this pull request Dec 6, 2016
@micbou micbou Revert PR #2279 2b3c9ad
@micbou micbou added a commit to micbou/YouCompleteMe that referenced this pull request Dec 18, 2016
@micbou micbou Revert PR #2279 85922ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment