Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single item contains #4

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@povilasb
Copy link

commented Oct 17, 2018

Makes contains matcher generic so that we could use it for both: vecs and single items, e.g.

conains(vec![1, 2])
contains(1)

See: #3


This change is Reviewable

povilasb added some commits Oct 17, 2018

Make contains matcher generic
That allows us to use the same matcher for both vec and single item:

    contains(vec![1, 2])
    contains(1)
@Valloric
Copy link
Owner

left a comment

Fantastic, I love it! Thanks for the PR!

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Valloric
Copy link
Owner

left a comment

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Valloric Valloric merged commit 12ce70b into Valloric:master Oct 17, 2018

2 checks passed

code-review/reviewable 3 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Valloric

This comment has been minimized.

Copy link
Owner

commented Mar 10, 2019

This has now been released as part of 0.2.4. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.