[READY] Bump Boost version to 1.63.0 #678

Merged
merged 1 commit into from Dec 30, 2016

Projects

None yet

5 participants

@micbou
Collaborator
micbou commented Dec 30, 2016 edited

The update_boost.py script was modified to remove the numpy folder (Numpy support was added in Boost 1.63.0) since it breaks the build and we don't need it.

This update makes it possible to compile ycmd with Visual Studio 2017 RC. See issue #656.


This change is Reviewable

@micbou micbou Bump Boost version to 1.63.0
dd69f29
@codecov-io
codecov-io commented Dec 30, 2016 edited

Current coverage is 92.52% (diff: 100%)

Merging #678 into master will not change coverage

@@             master       #678   diff @@
==========================================
  Files            79         79          
  Lines          5166       5166          
  Methods         295        295          
  Messages          0          0          
  Branches        139        139          
==========================================
  Hits           4780       4780          
  Misses          330        330          
  Partials         56         56          

Powered by Codecov. Last update 0cffd0d...dd69f29

@puremourning
Collaborator
puremourning commented Dec 30, 2016 edited

:lgtm:

@puremourning
Collaborator

Reviewed 149 of 149 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@micbou micbou changed the title from [WIP] Bump Boost version to 1.63.0 to [READY] Bump Boost version to 1.63.0 Dec 30, 2016
@vheon
Collaborator
vheon commented Dec 30, 2016

:lgtm: @homu r=puremourning


Reviewed 149 of 149 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@homu
Collaborator
homu commented Dec 30, 2016

📌 Commit dd69f29 has been approved by puremourning

@homu
Collaborator
homu commented Dec 30, 2016

⚡️ Test exempted - status

@homu homu merged commit dd69f29 into Valloric:master Dec 30, 2016

6 checks passed

code-review/reviewable Review complete: 2 of 2 LGTMs obtained
Details
codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing 0cffd0d...dd69f29
Details
codecov/project 92.52% (+0.00%) compared to 0cffd0d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@homu homu added a commit that referenced this pull request Dec 30, 2016
@homu homu Auto merge of #678 - micbou:boost-1.63.0, r=puremourning
[READY] Bump Boost version to 1.63.0

The `update_boost.py` script was modified to remove the `numpy` folder ([Numpy support was added in Boost 1.63.0](https://github.com/ndarray/Boost.NumPy#this-package-is-now-deprecated-in-favor-of-numpy-support-included-directly-in-boostpython)) since [it breaks the build](https://travis-ci.org/micbou/ycmd/jobs/187512286) and we don't need it.

This update makes it possible to compile ycmd with Visual Studio 2017 RC. See issue #656.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/678)
<!-- Reviewable:end -->
96aabdc
@micbou micbou deleted the micbou:boost-1.63.0 branch Jan 5, 2017
@puremourning puremourning referenced this pull request in Valloric/YouCompleteMe Jan 7, 2017
Merged

[READY] Update readme for compilation database support #2495

4 of 4 tasks complete
@homu homu added a commit to Valloric/YouCompleteMe that referenced this pull request Jan 8, 2017
@homu homu Auto merge of #2495 - puremourning:readme-compilation-database, r=micbou
[READY] Update readme for compilation database support

# PR Prelude

Thank you for working on YCM! :)

**Please complete these steps and check these boxes (by putting an `x` inside
the brackets) _before_ filing your PR:**

- [X] I have read and understood YCM's [CONTRIBUTING][cont] document.
- [X] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
- [X] I have included tests for the changes in my PR. If not, I have included a
  rationale for why I haven't.

> only changes docs

- [X] **I understand my PR may be closed if it becomes obvious I didn't
  actually perform all of these steps.**

# Why this change is necessary and useful

This change:
 - updates the c-family completer documentation to describe the built in support for compilation databases added in Valloric/ycmd#680
 - explains more about why ycmd needs compiler flags, and how to go about providing them
 - recommends using a compilation database (as that seems to be the fashion)
 - standardises formatting for `NOTE` (it was inconsistent before)
 - states that the preferred installation method is `install.py` (rather than the full installation instructions)
 - update the vim doc
 - update the ycmd submodule

### ycmd update release note

- Valloric/ycmd#678 - Bump Boost version to 1.63.0
- Valloric/ycmd#686 - Update JediHTTP for Python 3.6 support
- Valloric/ycmd#684 - Fix JavaScript identifier regex
- Valloric/ycmd#680 - Automatically load a compilation database if found

[cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
[code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2495)
<!-- Reviewable:end -->
d02de4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment