Update JediHTTP for Python 3.6 support #686

Merged
merged 1 commit into from Jan 7, 2017

Projects

None yet

5 participants

@hexchain
Contributor
hexchain commented Jan 7, 2017 edited

This change is Reviewable

@hexchain hexchain Update JediHTTP for Python 3.6 support
f2e5eb4
@hexchain
Contributor
hexchain commented Jan 7, 2017

Is it necessary to add more Python version to the CI build matrix too?

@micbou
Collaborator
micbou commented Jan 7, 2017

Thanks for the PR.

Is it necessary to add more Python version to the CI build matrix too?

No, the builds takes already too much time to complete. However, I would replace Python 3.5 by 3.6 on AppVeyor. It's fine to test against the last Python version on Windows. This can be done in another PR though.

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov-io
codecov-io commented Jan 7, 2017 edited

Current coverage is 92.52% (diff: 100%)

Merging #686 into master will not change coverage

@@             master       #686   diff @@
==========================================
  Files            79         79          
  Lines          5166       5166          
  Methods         295        295          
  Messages          0          0          
  Branches        139        139          
==========================================
  Hits           4780       4780          
  Misses          330        330          
  Partials         56         56          

Powered by Codecov. Last update 96aabdc...f2e5eb4

@puremourning
Collaborator

Thanks for doing this!!

:lgtm: @homu r+


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@homu
Collaborator
homu commented Jan 7, 2017

📌 Commit f2e5eb4 has been approved by puremourning

@homu
Collaborator
homu commented Jan 7, 2017

⚡️ Test exempted - status

@homu homu merged commit f2e5eb4 into Valloric:master Jan 7, 2017

6 checks passed

code-review/reviewable Review complete: 2 of 2 LGTMs obtained
Details
codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing 96aabdc...f2e5eb4
Details
codecov/project 92.52% (+0.00%) compared to 96aabdc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@homu homu added a commit that referenced this pull request Jan 7, 2017
@homu homu Auto merge of #686 - hexchain:update-python36, r=puremourning
Update JediHTTP for Python 3.6 support

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/686)
<!-- Reviewable:end -->
588dfe6
@homu homu added a commit that referenced this pull request Jan 8, 2017
@homu homu Auto merge of #687 - hexchain:update-ci-python, r=puremourning
Update Python version in CI environments to 3.6

This is the follow up of #686 (comment).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/687)
<!-- Reviewable:end -->
c9a4745
@homu homu added a commit to Valloric/YouCompleteMe that referenced this pull request Jan 8, 2017
@homu homu Auto merge of #2495 - puremourning:readme-compilation-database, r=micbou
[READY] Update readme for compilation database support

# PR Prelude

Thank you for working on YCM! :)

**Please complete these steps and check these boxes (by putting an `x` inside
the brackets) _before_ filing your PR:**

- [X] I have read and understood YCM's [CONTRIBUTING][cont] document.
- [X] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
- [X] I have included tests for the changes in my PR. If not, I have included a
  rationale for why I haven't.

> only changes docs

- [X] **I understand my PR may be closed if it becomes obvious I didn't
  actually perform all of these steps.**

# Why this change is necessary and useful

This change:
 - updates the c-family completer documentation to describe the built in support for compilation databases added in Valloric/ycmd#680
 - explains more about why ycmd needs compiler flags, and how to go about providing them
 - recommends using a compilation database (as that seems to be the fashion)
 - standardises formatting for `NOTE` (it was inconsistent before)
 - states that the preferred installation method is `install.py` (rather than the full installation instructions)
 - update the vim doc
 - update the ycmd submodule

### ycmd update release note

- Valloric/ycmd#678 - Bump Boost version to 1.63.0
- Valloric/ycmd#686 - Update JediHTTP for Python 3.6 support
- Valloric/ycmd#684 - Fix JavaScript identifier regex
- Valloric/ycmd#680 - Automatically load a compilation database if found

[cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
[code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2495)
<!-- Reviewable:end -->
d02de4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment