Fix unhandled exception for invalid numeric SteamIDs #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Too big integers or numeric strings raise TypeError in make_steam64 instead of returning valid SteamID object with the invalid flag set.
Examples:
SteamID(111111111111111111111111111111111111111)
SteamID('11111111111111111111111111111111111111')
rossengeorgiev
approved these changes
Apr 15, 2020
Member
rossengeorgiev
left a comment
rossengeorgiev
left a comment
There was a problem hiding this comment.
Looks good. I guess I've missed that obvious test case. Looks like the PR didn't run to CI for some reason, need that to run before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Росен!
First of all, thanks for your work on this project! Amazing library.
Upon creation of SteamID object, unhandled TypeError is raised for too large integers or numeric strings instead of creating SteamID object with the invalid flags set.
Example test is provided in the PR.
Cheers and have a nice day! 🍺