New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proton 3.16-2 compiled DXVK in debug mode? #1766

Closed
LeJimster opened this Issue Oct 17, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@LeJimster

LeJimster commented Oct 17, 2018

@Plagman @doitsujin
A couple of users over at GamingOnLinux noticed the performance has reduced and the file size of Proton 3.16 has increased quite a bit. It looks like a reoccurence of this issue #192. The DXVK dll's are much larger than they should be and I have tested one title I know well with noticeable reduced performance compared to 3.7-8.

@aeikum

This comment has been minimized.

Collaborator

aeikum commented Oct 17, 2018

Sigh, you're right. Looks like the fix for #192 was dropped in the move to the new build system. Thanks for reporting, will fix soon.

@kisak-valve kisak-valve added the cw label Oct 17, 2018

@LeJimster

This comment has been minimized.

LeJimster commented Oct 17, 2018

@aeikum does the bug affect Proton as a whole or just DXVK? adamhm over at GoL seems to think each Proton update since 3.7-6 are quite bloated and they do seem to be compared to his 3.7-6.

@aeikum

This comment has been minimized.

Collaborator

aeikum commented Oct 17, 2018

Yeah, I read those comments. We do purposely ship Wine with debug symbols included, so the binaries are large. However, Wine does correctly have -O2 optimizations enabled (and more incoming), so it shouldn't be impacted in the same way that DXVK is when built in debug mode. There was a bad build uploaded a long time ago that had symbols accidentally stripped and some other problems. That was build 3.7-2. My guess is that user snagged that and mis-labeled it as 3.7-6? Otherwise I don't know where they would've gotten a stripped wineserver from.

@Plagman

This comment has been minimized.

Member

Plagman commented Oct 17, 2018

This should be fixed, sorry about that.

@Plagman Plagman closed this Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment