Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HL2] Steampipe has stopped non-scripted actor NPC blinking #1850

Closed
ihonnyboy opened this issue Nov 17, 2014 · 19 comments
Closed

[HL2] Steampipe has stopped non-scripted actor NPC blinking #1850

ihonnyboy opened this issue Nov 17, 2014 · 19 comments

Comments

@ihonnyboy
Copy link

I'm referring to blinking of the eyes, not model blinking. I've asked friends and looked up previous footage of Half Life 2 before and after the steampipe update, and this is indeed the case. I tired looking through the code on this repository, but I can't make sense of it. I even fired up my xbox360 copy of the orange box to check that NPCs blinked on the orange box engine. Currently they blink when told to do so (view the flex sliders in a VCD file), but they won't blink "naturally." The opening sequence of Half Life 2 is a good example of this, the G-man doesn't blink at all, and the Citizens encountered afterward don't blink either.

@hitmen047
Copy link

hitmen047 commented Apr 15, 2016

As I see, Valve broke "blink" flex controling in c_baseflex.

@yaomtc
Copy link

yaomtc commented Oct 2, 2016

Two years later, and NPCs still aren't blinking. I wonder if Valve even saw this.

@idchlife
Copy link

idchlife commented Oct 8, 2016

Hey. Is there fix yet?

@Exileum
Copy link

Exileum commented Jan 20, 2017

@idchlife nope, but we hope 👀

@stalcer
Copy link

stalcer commented Jan 20, 2017

MAKE NPCS BLINK AGAIN!

@flymans
Copy link

flymans commented Jan 20, 2017

Fix it, please.

@martind0
Copy link

Blink hype! 😄

@playr0097
Copy link

I hope that they fix this, it's annoying.

@hitmen047
Copy link

Easy to fix: https://www.youtube.com/watch?v=NEABoX3eF_g

@yaomtc
Copy link

yaomtc commented Jan 30, 2017

Hey guys, please don't spam. The only reason to comment on here is if you have a question, or something helpful to add - like a video demonstrating how it should be (thanks hitmen047), or a comment saying that the bug is either fixed or still not fixed after an update, or a significant amount of time has passed. This isn't YouTube. Everybody following this gets notified of useless comments and it's pretty annoying.

Hey hitmen, is that your video? I'm wondering how they/you fixed it.

@Exileum
Copy link

Exileum commented Jan 30, 2017

@yaomtc unsubscribe from thread and you didn't receive notifications.

@yaomtc
Copy link

yaomtc commented Jan 30, 2017

@Exile37 of course I want to receive notifications... How else will I know when it's fixed? The problem isn't in my having subscribed, the problem is with users adding noise when they can just add an emoji, which is the reason they added them! https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments

They even added the ability to sort a repo's issues by number of specific reactions: isaacs/github#527

I don't want to fill up this thread with more comments that aren't about the blinking, so that's all I've got to say.

@hitmen047
Copy link

@yaomtc yes, I'm the author of this video. I described the problem above in this thread. The problem in "blink" flex controlling in c_baseflex.cpp on client side. Looks like Valve changed it for TF2.

@GamerDude27
Copy link

@hitmen047 How exactly did you fix the problem?

@NicknineTheEagle
Copy link

NicknineTheEagle commented Aug 21, 2017

Didn't take too long to figure out the cause.
https://github.com/ValveSoftware/source-sdk-2013/blob/master/sp/src/game/client/c_baseflex.cpp#L1152
This shouldn't be here.

@idchlife
Copy link

@NicknineTheEagle a hero we always wanted. Nice work!

@kisak-valve
Copy link
Member

Closing as fixed per "Fixed NPCs not blinking" in the 2019-09-26 Half Life 2 series game update.

@Pikamander2
Copy link

https://www.rockpapershotgun.com/2019/09/27/half-life-2s-downtrodden-npcs-have-been-unable-to-blink-for-five-years-until-now/

@hirowatch
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests