New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastDL does not URLEncode the request URI #2056

Open
SamVanheer opened this Issue Nov 18, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@SamVanheer
Copy link

SamVanheer commented Nov 18, 2018

When the FastDL download manager sends the HTTP request to download a file it does not URLEncode the URI which can result in files with spaces or other unsupported characters not downloading (properly).

The URI should be encoded in DownloadManager::StartNewDownload before passing the complete URI into ISteamHTTP::CreateHTTPRequest.

The documentation for that method makes no mention of URL encoding so i assume it does not do this internally. Since downloads with spaces fail, this reinforces the assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment