New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install script steam{,.sh} is not POSIX compliant #623

Closed
hasufell opened this Issue Jan 9, 2013 · 5 comments

Comments

Projects
None yet
4 participants
@hasufell

hasufell commented Jan 9, 2013

It would be a portability improvement to make the install scripts posix compliant without forcing a particular shell (in this case bash).

proposing patch: https://gist.github.com/6d85b0c4d234641fc112

for references about bashisms, see:
http://mywiki.wooledge.org/Bashism
https://wiki.ubuntu.com/DashAsBinSh

you can check for bashisms with this popular perl script: http://sourceforge.net/projects/checkbaskisms/

@hasufell hasufell referenced this issue Jan 9, 2013

Closed

steam-base-9999 #17

@ghost ghost assigned slouken and triage-valve Jan 9, 2013

@velociostrich

This comment has been minimized.

velociostrich commented Jan 11, 2013

I see you're using $() in a number of places. That is itself a bashism; you should use backticks (`) instead.

@hasufell

This comment has been minimized.

hasufell commented Jan 11, 2013

afais $() is defined in POSIX
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03

however, it would probably be fine to fix it to `` syntax although I remember there are slight differences, will test that first

@velociostrich

This comment has been minimized.

velociostrich commented Jan 11, 2013

How about that. I swear there was a version of dash (FOSS sh implementation) whose man page did not list $(). Either I'm mistaken or there was in fact a version of dash that lacked $(). (Which would not have made dash POSIX compliant, and I just incorrectly assumed that it's man page was in line with POSIX.)

@hasufell

This comment has been minimized.

hasufell commented Jan 12, 2013

It seems to be invalid syntax in "tcsh"... seems that this shell is not posix compliant after all.

@hasufell

This comment has been minimized.

hasufell commented May 24, 2016

No action here, no interest in redoing, bye.

@hasufell hasufell closed this May 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment