Fix #13: move UpdateAdaptiveQuality() to LateUpdate. #17

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

TrebuhD commented Oct 19, 2016

Fix the adaptive quality screen flicker bug by moving UpdateAdaptiveQuality() from OnPreCull() to LateUpdate() in ValveCamera.cs, as suggested by @Selkcip.

@TrebuhD TrebuhD move UpdateAdaptiveQuality() to LateUpdate.
Fix the adaptive quality screen flicker bug by moving
UpdateAdaptiveQuality() from OnPreCull() to LateUpdate().
b3e0d0f

I still get a "jump" anytime it changes quality. Is that to be expected? Seems like not.

I guess it's not every time it changes quality, but there is certainly an increase in the lurches that I get.

Selkcip commented Oct 29, 2016

Is it hitching or are you seeing a skewed frame? This won't fix occasional hitching, but does fix a serious bug where a single, very obvious, frame would be rendered with the wrong viewport dimensions making things unplayable.

It was hitching, as it turns out. Not sure if it was reimporting the assets or bumping up my unity version, but one of the two solved it. I think I was getting hitching+the frame thing before, and this definitely fixed the frame badness, but left the hitching (because it was my fault 😿 ). Anyways, this LGTM!

it does fixed flickering by moving UpdateAdaptiveQuality(); to lateupdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment