New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even after the spider is dead I still have to fight him. #5

Closed
shirishag75 opened this Issue Aug 22, 2012 · 7 comments

Comments

Projects
None yet
2 participants
@shirishag75

shirishag75 commented Aug 22, 2012

Even after the spider is dead, he's not dead and I can't chose slime to fight. I'm locked in combat with the spider only. There is no error on the CLI.

@Bertram25

This comment has been minimized.

Member

Bertram25 commented Aug 22, 2012

Ah, nice catch. Yet, I do wonder how you came to this situation.

  • In what order did you kill the monsters?
  • Did you kill the slime first?
  • Did you try to change the target afterward?
@shirishag75

This comment has been minimized.

shirishag75 commented Aug 23, 2012

Tried to kill the spider first, did kill him ( or atleast the spider picture/animation is not there) but still when fighting I am/was only able to target the spider (even when there's nothing there in the blank space.) .

The slime was not killed at all.

Of course I tried changing the target but found I couldn't/can't.

@Bertram25

This comment has been minimized.

Member

Bertram25 commented Aug 23, 2012

Duly noted. I'll make tests the following days.

Tried to kill the spider first, did kill him ( or atleast the spider
picture/animation is not there) but still when fighting I am/was only able
to target the spider (even when there's nothing there in the blank space.)
.

The slime was not killed at all.

Of course I tried changing the target but found I couldn't/can't.


Reply to this email directly or view it on GitHub:
#5 (comment)

@Bertram25

This comment has been minimized.

Member

Bertram25 commented Aug 27, 2012

Ok, here is a first pass that should help getting out of the impossibility to select the slime (in that specific case).
6e5f58f

It is yet hard to reproduce, so I'm not 100% sure it is fixed using that commit. Anyway, that commit can't hurt at all since the logic there was weak anyway.

@Bertram25

This comment has been minimized.

Member

Bertram25 commented Aug 28, 2012

Missing: Make the character cancel its enemy target selection if the enemy target in question dies.

@Bertram25

This comment has been minimized.

Member

Bertram25 commented Aug 29, 2012

I have the patch. I'll commit asap.

@ghost ghost assigned Bertram25 Aug 29, 2012

@Bertram25

This comment has been minimized.

Member

Bertram25 commented Aug 29, 2012

The missing part has been pushed:
33cfdb1
I consider this as closed. Feel free to reopen it if relevant.

@Bertram25 Bertram25 closed this Aug 29, 2012

IkarusDowned referenced this issue in IkarusDowned/ValyriaTear Mar 30, 2013

passive effects from equipment applied
equipment now gives "passive" application of status to your character!
An easy way to try this out is to simply add a extreme strength modifier
to the Arbalest, and watch Kayla do some SERIOUS damage!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment