New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English language text improvements #27

Merged
merged 1 commit into from Nov 6, 2012

Conversation

Projects
None yet
2 participants
@rootslinux
Contributor

rootslinux commented Nov 6, 2012

I went through nearly every line of English text that is seen by the player (covered the entire /dat directory) and updated various lines to read better. The major changes included:

  • Fixed all grammatical errors and oddities
  • Improved the word order and phrasing of some lines of dialogue
  • Made punctuation usage more consistent throughout all the text
  • Changed the punctuation in some spoken lines to make better sense (it's very strange for "!" to be followed by "...", for example)

What I did not change:

  • No lines of dialogue were added or removed
  • Almost all of the expressions ("Ah ah", "Err", etc) remained intact, although I personally think that such language is used much too frequently in the game dialogues so far.
@Bertram25

This comment has been minimized.

Member

Bertram25 commented Nov 6, 2012

Thanks!

The sentences are indeed looking better. :)
I must say that most punctuation errors are coming from my own frenchy style. Ah, and I didn't know about the word yougins. ;)

Almost all of the expressions ("Ah ah", "Err", etc) remained intact, although I personally think that such language is used much too frequently in the game dialogues so far.

I'll take that into account, thanks. I must say that I've created most of the dialogue before developing the emote system. But I know this is only a partial excuse. ;)

Anyway, this has my review and should be merged now.

Bertram25 added a commit that referenced this pull request Nov 6, 2012

Merge pull request #27 from rootslinux/master
English language text improvements

@Bertram25 Bertram25 merged commit 80b5d85 into ValyriaTear:master Nov 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment