diff --git a/pkg/controller/jobs/job/job_controller_test.go b/pkg/controller/jobs/job/job_controller_test.go index 32e4df339e..cef6728171 100644 --- a/pkg/controller/jobs/job/job_controller_test.go +++ b/pkg/controller/jobs/job/job_controller_test.go @@ -402,6 +402,11 @@ func TestReconciler(t *testing.T) { Request(corev1.ResourceCPU, "1"). Image("", nil) + baseWorkloadWrapper := utiltesting.MakeWorkload("wl", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). + PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). + ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()) + baseWPCWrapper := utiltesting.MakeWorkloadPriorityClass("test-wpc"). PriorityValue(100) @@ -427,9 +432,7 @@ func TestReconciler(t *testing.T) { PodLabel("ac-key", "ac-value"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check", @@ -446,10 +449,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check", @@ -482,9 +482,7 @@ func TestReconciler(t *testing.T) { Suspend(false). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Active(false). AdmissionCheck(kueue.AdmissionCheckState{ @@ -499,10 +497,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Active(false). Condition(metav1.Condition{ @@ -531,9 +526,7 @@ func TestReconciler(t *testing.T) { Suspend(true). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Active(false). Condition(metav1.Condition{ @@ -557,10 +550,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Active(false). Condition(metav1.Condition{ @@ -613,9 +603,7 @@ func TestReconciler(t *testing.T) { Suspend(true). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Active(false). Queue("foo"). @@ -646,10 +634,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Active(false). Queue("foo"). @@ -687,9 +672,7 @@ func TestReconciler(t *testing.T) { Suspend(true). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -718,10 +701,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -763,9 +743,7 @@ func TestReconciler(t *testing.T) { Suspend(true). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -794,10 +772,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -839,9 +814,7 @@ func TestReconciler(t *testing.T) { Suspend(true). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -870,10 +843,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -917,9 +887,7 @@ func TestReconciler(t *testing.T) { NodeSelector("provisioning", "spot"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check", @@ -936,10 +904,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check", @@ -974,9 +939,7 @@ func TestReconciler(t *testing.T) { NodeSelector("node-selector-key2", "only-in-check2"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -1019,10 +982,7 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). AdmissionCheck(kueue.AdmissionCheckState{ Name: "check1", @@ -1082,17 +1042,12 @@ func TestReconciler(t *testing.T) { Suspend(false). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Obj(), }, @@ -1112,9 +1067,8 @@ func TestReconciler(t *testing.T) { job: *baseJobWrapper.DeepCopy(), wantJob: *baseJobWrapper.DeepCopy(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *baseWorkloadWrapper.Clone(). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 5).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). Admitted(true). Obj(), }, @@ -1124,7 +1078,7 @@ func TestReconciler(t *testing.T) { Key: types.NamespacedName{Name: "job", Namespace: "ns"}, EventType: "Normal", Reason: "DeletedWorkload", - Message: "Deleted not matching Workload: ns/a", + Message: "Deleted not matching Workload: ns/wl", }, }, }, @@ -1135,13 +1089,15 @@ func TestReconciler(t *testing.T) { job: *baseJobWrapper.DeepCopy(), wantJob: *baseJobWrapper.DeepCopy(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("a", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 5).Request(corev1.ResourceCPU, "1").Obj()). Priority(0). Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("a", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("foo"). Priority(0). @@ -1169,14 +1125,15 @@ func TestReconciler(t *testing.T) { Parallelism(8). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("a", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).SetMinimumCount(5).Request(corev1.ResourceCPU, "1").Obj()). ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(8).Obj()). Admitted(true). Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("a", "ns"). Finalizers(kueue.ResourceInUseFinalizerName). PodSets( *utiltesting.MakePodSet(kueue.DefaultPodSetName, 10). @@ -1209,7 +1166,8 @@ func TestReconciler(t *testing.T) { SetAnnotation(JobMinParallelismAnnotation, "5"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("a", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets( *utiltesting.MakePodSet(kueue.DefaultPodSetName, 10). SetMinimumCount(5). @@ -1249,7 +1207,8 @@ func TestReconciler(t *testing.T) { UID("test-uid"). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("test-queue"). Priority(0). @@ -1286,7 +1245,8 @@ func TestReconciler(t *testing.T) { UID("test-uid"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("test-queue"). Priority(0). @@ -1296,7 +1256,8 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("test-queue-new"). Priority(0). @@ -1317,7 +1278,8 @@ func TestReconciler(t *testing.T) { UID("test-uid"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("foo"). Priority(0). @@ -1328,7 +1290,8 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("foo"). Priority(0). @@ -1352,7 +1315,8 @@ func TestReconciler(t *testing.T) { UID(strings.Repeat("long-uid", 8)). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("test-queue"). Priority(0). @@ -1461,13 +1425,15 @@ func TestReconciler(t *testing.T) { Obj(), }, workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("parent-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("parent-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).SetMinimumCount(5).Request(corev1.ResourceCPU, "1").Obj()). ControllerReference(batchv1.SchemeGroupVersion.WithKind("Job"), "parent", "parent"). Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("parent-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("parent-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).SetMinimumCount(5).Request(corev1.ResourceCPU, "1").Obj()). ControllerReference(batchv1.SchemeGroupVersion.WithKind("Job"), "parent", "parent"). Obj(), @@ -1500,7 +1466,8 @@ func TestReconciler(t *testing.T) { Obj(), }, workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("parent-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("parent-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).SetMinimumCount(5).Request(corev1.ResourceCPU, "1").Obj()). ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). ControllerReference(batchv1.SchemeGroupVersion.WithKind("Job"), "parent", "parent"). @@ -1508,7 +1475,8 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("parent-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("parent-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).SetMinimumCount(5).Request(corev1.ResourceCPU, "1").Obj()). ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). ControllerReference(batchv1.SchemeGroupVersion.WithKind("Job"), "parent", "parent"). @@ -1531,17 +1499,20 @@ func TestReconciler(t *testing.T) { Parallelism(5). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("first-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("first-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 5).Request(corev1.ResourceCPU, "1").Obj()). ReserveQuota(utiltesting.MakeAdmission("cq").Obj()). Admitted(true). Obj(), - *utiltesting.MakeWorkload("second-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("second-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).SetMinimumCount(5).Request(corev1.ResourceCPU, "1").Obj()). Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("first-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("first-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 5).Request(corev1.ResourceCPU, "1").Obj()). ReserveQuota(utiltesting.MakeAdmission("cq").Obj()). Admitted(true). @@ -1565,10 +1536,7 @@ func TestReconciler(t *testing.T) { Active(10). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Condition(metav1.Condition{ Type: kueue.WorkloadEvicted, @@ -1581,9 +1549,7 @@ func TestReconciler(t *testing.T) { Active(10). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Condition(metav1.Condition{ Type: kueue.WorkloadEvicted, @@ -1607,9 +1573,7 @@ func TestReconciler(t *testing.T) { Active(10). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Condition(metav1.Condition{ Type: kueue.WorkloadEvicted, @@ -1622,9 +1586,7 @@ func TestReconciler(t *testing.T) { Active(10). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Condition(metav1.Condition{ Type: kueue.WorkloadEvicted, @@ -1640,9 +1602,7 @@ func TestReconciler(t *testing.T) { Active(10). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Condition(metav1.Condition{ Type: kueue.WorkloadEvicted, @@ -1655,9 +1615,7 @@ func TestReconciler(t *testing.T) { Active(10). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Condition(metav1.Condition{ Type: kueue.WorkloadEvicted, @@ -1671,10 +1629,7 @@ func TestReconciler(t *testing.T) { Condition(batchv1.JobCondition{Type: batchv1.JobComplete, Status: corev1.ConditionTrue}). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Obj(), }, @@ -1682,10 +1637,7 @@ func TestReconciler(t *testing.T) { Condition(batchv1.JobCondition{Type: batchv1.JobComplete, Status: corev1.ConditionTrue}). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). - Finalizers(kueue.ResourceInUseFinalizerName). - PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). - ReserveQuota(utiltesting.MakeAdmission("cq").AssignmentPodCount(10).Obj()). + *baseWorkloadWrapper.Clone(). Admitted(true). Condition(metav1.Condition{ Type: kueue.WorkloadFinished, @@ -1700,14 +1652,14 @@ func TestReconciler(t *testing.T) { Key: types.NamespacedName{Name: "job", Namespace: "ns"}, EventType: "Normal", Reason: "FinishedWorkload", - Message: "Workload 'ns/a' is declared finished", + Message: "Workload 'ns/wl' is declared finished", }, }, }, "when the workload is finished, its finalizer is removed": { job: *baseJobWrapper.Clone().Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("a", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("a", "ns"). Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet("main", 10).Request(corev1.ResourceCPU, "1").Obj()). Condition(metav1.Condition{ @@ -1753,7 +1705,8 @@ func TestReconciler(t *testing.T) { WorkloadPriorityClass("test-wpc"). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").Obj()). Queue("test-queue"). PriorityClass("test-wpc"). @@ -1797,7 +1750,8 @@ func TestReconciler(t *testing.T) { PriorityClass("test-pc"). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-pc"). @@ -1843,7 +1797,8 @@ func TestReconciler(t *testing.T) { PriorityClass("test-pc"). Obj(), wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("job", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("job", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-wpc"). @@ -1913,7 +1868,8 @@ func TestReconciler(t *testing.T) { UID("test-uid"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("prebuilt-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("prebuilt-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-wpc"). @@ -1922,7 +1878,8 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("prebuilt-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("prebuilt-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-wpc"). @@ -1956,7 +1913,8 @@ func TestReconciler(t *testing.T) { UID("test-uid"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("prebuilt-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("prebuilt-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-wpc"). @@ -1966,7 +1924,8 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("prebuilt-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("prebuilt-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 10).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-wpc"). @@ -1997,7 +1956,8 @@ func TestReconciler(t *testing.T) { UID("test-uid"). Obj(), workloads: []kueue.Workload{ - *utiltesting.MakeWorkload("prebuilt-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("prebuilt-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 1).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-wpc"). @@ -2006,7 +1966,8 @@ func TestReconciler(t *testing.T) { Obj(), }, wantWorkloads: []kueue.Workload{ - *utiltesting.MakeWorkload("prebuilt-workload", "ns").Finalizers(kueue.ResourceInUseFinalizerName). + *utiltesting.MakeWorkload("prebuilt-workload", "ns"). + Finalizers(kueue.ResourceInUseFinalizerName). PodSets(*utiltesting.MakePodSet(kueue.DefaultPodSetName, 1).Request(corev1.ResourceCPU, "1").PriorityClass("test-pc").Obj()). Queue("test-queue"). PriorityClass("test-wpc").