Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify SSO callback funcs #13

Closed
cktang88 opened this issue Apr 23, 2019 · 0 comments · Fixed by #261
Closed

Unify SSO callback funcs #13

cktang88 opened this issue Apr 23, 2019 · 0 comments · Fixed by #261
Labels
good first issue Good for newcomers Type: Chore Maintainance, refactoring, code cleanup

Comments

@cktang88
Copy link
Contributor

https://github.com/VandyHacks/vaken/blob/dev/src/server/api/UserRouter.ts

Github and Google SSO callback handlers are basically the same --> refactor as one func taking params.
@cktang88 cktang88 added good first issue Good for newcomers Type: Chore Maintainance, refactoring, code cleanup and removed good first issue Good for newcomers labels Apr 23, 2019
@github-actions github-actions bot mentioned this issue Jul 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Type: Chore Maintainance, refactoring, code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement graphql-code-generator for type-safe fun in the sun VandyHacks/vaken
1 participant
@cktang88