New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19 #21

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@Mte90
Contributor

Mte90 commented Oct 4, 2018

No description provided.

run.sh Outdated
echo -e "\033[0;33mAlso, do not run this on a USB drive. Run it on an SSD then copy the final result\033[0m"
for path in "${not_suggested_path[@]}" ; do
if [[ $current_directory = *$path* ]]; then
read -p "You are trying run this on a USB drive (slowness and issue on executing the script). Do you want to proceed?" -n 1 -r

This comment has been minimized.

@tomjn

tomjn Oct 12, 2018

Member

I think it should recommend that this be ran on an SSD/HD still, else people are likely to just say yes

This comment has been minimized.

@Mte90

Mte90 Oct 12, 2018

Contributor

so only change the text

@tomjn tomjn added the enhancement label Oct 12, 2018

@tomjn tomjn requested review from Varying-Vagrant-Vagrants/committers Oct 12, 2018

@tomjn

tomjn approved these changes Oct 16, 2018

@tomjn tomjn merged commit 8e6e0e0 into Varying-Vagrant-Vagrants:master Oct 16, 2018

@tomjn

This comment has been minimized.

Member

tomjn commented Oct 16, 2018

Hopefully we can integrate this into the vagrant file too and run it when contributor day mode is enabled

@Mte90

This comment has been minimized.

Contributor

Mte90 commented Oct 16, 2018

Not a bad idea to port also there :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment