Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Core JS build changing #1447

Open
tomjn opened this Issue Mar 9, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@tomjn
Copy link
Member

tomjn commented Mar 9, 2018

https://core.trac.wordpress.org/ticket/43055

TLDR we can't run the src and build folders in parallel as a build step is necessary, meaning src will never work properly

We should take this as an opportuntiy to fix up https://github.com/Varying-Vagrant-Vagrants/custom-site-template-develop and deprecate the old develop site template

@LoreleiAurora

This comment has been minimized.

Copy link
Member

LoreleiAurora commented Mar 9, 2018

Just to note:
i wouldnt auto run grunt watch in the background, it does not work great on mapped folders.

@tomjn

This comment has been minimized.

Copy link
Member Author

tomjn commented Mar 9, 2018

Thoughts on the deprecation of wordpress-develop in favour of custom-site-develop:

  • What if we modify the provisioner to insert an MU plugin that puts a notice in the admin bar warning the site template is deprecated and linking to migration instructions?
  • We'll need migration instructions, though I'd expect anybody doing core dev could do it themselves
  • We'll need to change the vvv-config.yml so new users get custom-site-develop
  • The vvv mu plugin that lets you fast switch from src to build will need to go away :(
  • A notice in the dashboard would probably be helpful
  • Visiting src will give a wp_die with a warning, instead perhaps we should modify the nginx config to redirect to the trac ticket or a doc? Maybe serve a static html file instead?
@pento

This comment has been minimized.

Copy link

pento commented Apr 5, 2018

Just dropping in to give y'all an update on the JS reorg work. 🙂

Because grunt watch (or any watching-type build tool) is a less-than-fun time with mapped folders, I think the best option for Core is going to involve moving to a more opinionated development environment. We've found Gutenberg's setup scripts to be quite useful, so will probably move in a similar direction in Core.

With that in mind, I would suggest you move in the direction that makes the most sense for VVV, rather than being concerned with Core devs being able to setup a VVV-based development environment. Certainly, I think the folks most familiar with VVV/Vagrant would appreciate a way to keep using it, but I agree that you can expect current core devs to be able to do the migration themselves.

@tomjn

This comment has been minimized.

Copy link
Member Author

tomjn commented Apr 5, 2018

I agree that you can expect current core devs to be able to do the migration themselves.

Given that VVV gets installed on contributor days, I'm keen to make sure VVV is usable out of the box for this, if only for inclusivity and to help first time contributors

@tomjn

This comment has been minimized.

Copy link
Member Author

tomjn commented Apr 5, 2018

@pento I can't see anything in the GB scripts of note other than a docker call and a splash screen with some checks for existing tools, are you saying Core development will be using a docker container in future? Or that VVV is no longer to be used for core dev?

@pento

This comment has been minimized.

Copy link

pento commented Apr 6, 2018

I'm not saying VVV can't be used for core dev, and it's a little premature of me to be saying that Docker is the right option, it's just the option that's worked well for Gutenberg so far.

@omarreiss will be opening a Core ticket where we can discuss the details of the pros and cons of each option. I'm certainly convinced that, with Core moving to a more complicated contribution process, we need to make it significantly easier for people to contribute. Part of that is automating setting up a development environment for people who aren't in a position to choose one for themselves.

The actual tool that sits behind that automation could easily be Docker or VVV, that's mostly a question of which is a better fit.

@tomjn tomjn referenced this issue May 16, 2018

Open

VVV 3 Roadmap #1469

@earnjam

This comment has been minimized.

Copy link

earnjam commented May 29, 2018

Since this change is part of WP trunk now, https://github.com/Varying-Vagrant-Vagrants/custom-site-template-develop/ actually doesn't work at the moment. It defaults to using src when the vvv_env cookie isn't set, so unless you set that manually, or else change the nginx config directly, you can't get to the develop environment.

@tomjn

This comment has been minimized.

Copy link
Member Author

tomjn commented May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.