Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document requirement for WP_CACHE_KEY_SALT #1560

Closed
paulschreiber opened this Issue Jun 21, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@paulschreiber
Copy link
Contributor

paulschreiber commented Jun 21, 2018

When using the object-cache.php drop-in, users will see unexpected behaviour (such as being redirected to site A when they attempt to load site B).

To avoid this, one must define WP_CACHE_KEY_SALT in wp-config.php.

It would be very helpful to put this in the VVV docs.

@tomjn

This comment has been minimized.

Copy link
Member

tomjn commented Jun 21, 2018

It would be better to adjust custom-site-template to add such a salt to wp-config.php, but I don't believe that's something VVV should spend a lot of time documenting, since it's not VVV specific and applies to any WP install

@tomjn tomjn added the documentation label Jun 21, 2018

@paulschreiber

This comment has been minimized.

Copy link
Contributor Author

paulschreiber commented Jun 21, 2018

@tomjn Adding it automatically sounds even better.

I also filed a ticket requesting the WordPress.org salt service generate this:
https://core.trac.wordpress.org/ticket/44425

@tomjn

This comment has been minimized.

Copy link
Member

tomjn commented Jun 21, 2018

@paulschreiber it looks like VVV doesn't do anything regarding salts, and the source of the existing salts is actually WP CLI, a WP CLI adjustment would be the appropriate fix

I've created a PR that should resolve this in a future WP CLI update. Once it's merged and released VVV will grab the update

wp-cli/config-command#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.