Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options on site template #1632

Closed
Mte90 opened this issue Sep 14, 2018 · 11 comments · Fixed by Varying-Vagrant-Vagrants/custom-site-template#14
Closed

Add more options on site template #1632

Mte90 opened this issue Sep 14, 2018 · 11 comments · Fixed by Varying-Vagrant-Vagrants/custom-site-template#14
Labels

Comments

@Mte90
Copy link
Contributor

@Mte90 Mte90 commented Sep 14, 2018

Talking with other devs can be handy to add more option on https://github.com/Varying-Vagrant-Vagrants/custom-site-template like to change the locale and define settings in the wp-config and also suite of plugins already available.

@Mte90 Mte90 added the enhancement label Sep 14, 2018
@Mte90

This comment has been minimized.

Copy link
Contributor Author

@Mte90 Mte90 commented Oct 4, 2018

I will try to work on that in the next days

@Mte90

This comment has been minimized.

Copy link
Contributor Author

@Mte90 Mte90 commented Oct 19, 2018

I think that we can integrate https://github.com/JPry/vvv-base or a little part

@tomjn

This comment has been minimized.

Copy link
Member

@tomjn tomjn commented Oct 19, 2018

So that templates provisioner uses PHP to do all its work. I think a lot of basic stuff could be done via WP CLI to replicate most of what it does. I'm not a big fan of the inline JSON in YAML though, I'd prefer to see things 100% YAML so that the file can be checked with a schema and validator

@Mte90

This comment has been minimized.

Copy link
Contributor Author

@Mte90 Mte90 commented Oct 20, 2018

Yes my idea is to replicate it many of them without PHP but pure bash using wp-cli.

@dingo-d

This comment has been minimized.

Copy link

@dingo-d dingo-d commented Dec 14, 2018

Would it be a good idea to add a branch besides a repo field when creating sites using custom site template?

Use-case:
Say you want to use the older version where you don't have Gutenberg installed. You have custom-site-template.git and in master branch you have latest WP, and you could add 4.9.8 branch where you'd set up that older version of WP is installed while provisioning.

That way you can reuse custom site template (one repo multiple branches).

@tomjn

This comment has been minimized.

Copy link
Member

@tomjn tomjn commented Dec 14, 2018

@dingo-d

This comment has been minimized.

Copy link

@dingo-d dingo-d commented Dec 16, 2018

How? I can only add git repo. I didn't see a branch key (or any mention of it).

@tomjn

This comment has been minimized.

Copy link
Member

@tomjn tomjn commented Dec 16, 2018

There's a branch key, but it determines the branch of the git repo. WP installation etc is the responsibility of the site provisioner not VVV core.

If you look at the custom site template docs, you can specify the WP version:

my-site:
  repo: https://github.com/Varying-Vagrant-Vagrants/custom-site-template
  hosts:
    - multisite.test
  custom:
    wp_type: subdirectory
    wp_version: 4.6.4
@dingo-d

This comment has been minimized.

Copy link

@dingo-d dingo-d commented Dec 17, 2018

So if I understood correctly, in my custom-site-template I'd create a 4.6.4 branch, and in there in the provisioner, I'd set the wp version in the provision.sh, right? I was thinking of something like that, it's just that I wasn't aware of the wp_type and wp_version (couldn't find anything about it in the docs)

@tomjn

This comment has been minimized.

Copy link
Member

@tomjn tomjn commented Dec 27, 2018

@Mte90

This comment has been minimized.

Copy link
Contributor Author

@Mte90 Mte90 commented Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.