Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ship 1.2.0 #510
We've been hanging in 1.1 land FOREVER. :) Mostly due to our licensing, which is lovingly figured out now.
I'd like to ship 1.2 this weekend. This doesn't mean too much, as we get plenty of new clones every day, so the
If anybody has other checklist items, chime away!
Making some notes while I do the v1.1 to v1.2 check.
And all is wonderful. Nice. I really did not expect it to go this well. :)
Just curious. If you are going through a box change in 1.2, so there isn't a direct upgrade path from 1.1 couldn't this be an opportunity to actually implement pr#460 which was closed because it would likely result in some issues with the existing naming of the running machines?
I just noticed it is kind of in there. You just did
Two methods which I had originally found via SO which wasn't actually any clearer.
I will check to see if there are any points where your hostname fails to replace the default. I had also thought of perhaps reading the parent directory for naming the hostname. It would be dynamic and hopefully prevent collisions by allowing multiple vvvs on a single host by using different directory names.
Update: Read through the commit history for that line and realized it isn't related to what I had done. Still I would be curious if a 1.2 release with a change as large as the box might be a possible point to merge my pull request. I updated it with PR 512 which uses the folder name so even multiple instances of vvv could exist if they were in differently named folders.