New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple php versions through vvv-config.yml & utilities #1055

Merged
merged 9 commits into from Dec 15, 2016

Conversation

Projects
None yet
2 participants
@LoreleiAurora
Member

LoreleiAurora commented Dec 15, 2016

This adds an additional optional variable of upstream to vvv-config.yml to allow you to set the nginx upstream.
It also switches xDebug from source to the PPA as this is compatible with multiple PHP versions.

An example config for testing:

---
sites:
  wordpress-default:
    repo: https://github.com/Varying-Vagrant-Vagrants/vvv-wordpress-default.git
    nginx_upstream: php71
    hosts:
      - local.wordpress.dev

  wordpress-develop:
    repo: https://github.com/Varying-Vagrant-Vagrants/vvv-wordpress-develop.git
    nginx_upstream: php56
    hosts:
      - src.wordpress-develop.dev
      - build.wordpress-develop.dev

  wordpress-trunk:
    repo: https://github.com/Varying-Vagrant-Vagrants/vvv-wordpress-trunk.git
    hosts:
      - local.wordpress-trunk.dev

utilities:
  core:
    - memcached-admin
    - opcache-status
    - phpmyadmin
    - webgrind
    - php56
    - php71

Requires Varying-Vagrant-Vagrants/vvv-utilities#3 to stop my custom repo being needed.

@jeremyfelt

This is pretty slick! I left a couple comments inline. We should also update at least the wordpress-develop repository with the new nginx template variables, even if they end up being the default settings. This should help as a guide.

Show outdated Hide outdated Vagrantfile Outdated
Show outdated Hide outdated config/nginx-config/nginx.conf Outdated
@jeremyfelt

This comment has been minimized.

Show comment
Hide comment
@jeremyfelt

jeremyfelt Dec 15, 2016

Member

No reason to keep this waiting. I'll have time to do some more testing this weekend, but I'd like to get this in earlier than later. Thanks @LoreleiAurora!

Member

jeremyfelt commented Dec 15, 2016

No reason to keep this waiting. I'll have time to do some more testing this weekend, but I'd like to get this in earlier than later. Thanks @LoreleiAurora!

@jeremyfelt jeremyfelt merged commit f38b82a into Varying-Vagrant-Vagrants:develop Dec 15, 2016

@LoreleiAurora LoreleiAurora deleted the LoreleiAurora:multi-php branch Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment