Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1876 - remove nvm #1879

Merged
merged 4 commits into from Jun 27, 2019

Conversation

@Mte90
Copy link
Contributor

commented Jun 27, 2019

@tomjn

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

hmmm do we need to do something to npm to make sure the linkage is undone and put back how it's supposed to be? perhaps nvm use system?

@tomjn

tomjn approved these changes Jun 27, 2019

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

it is not enough because the permission on npm are not right and I have to rebase it.

@Mte90 Mte90 force-pushed the Mte90:remove-nvm branch from 5bd8be0 to 2563fd7 Jun 27, 2019

@Mte90 Mte90 marked this pull request as ready for review Jun 27, 2019

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

The problem is that require a vagrant destroy because apt will not downgrade the nodejs version because the 11 is already used.

@Mte90 Mte90 merged commit e18cd13 into Varying-Vagrant-Vagrants:develop Jun 27, 2019

@Mte90 Mte90 deleted the Mte90:remove-nvm branch Jun 27, 2019

@tomjn

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

@Mte90 can we just check the node version? If it's 11, apt uninstall, do an apt update, then reinstall?

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

manually yes it is possible but in case people has troubles we a destroy is more easy (sure at this point the nvm check is not required anymore).

@tomjn

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

This was done in #1880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.