Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1417 - Github Token in vvv-config #1896

Merged
merged 3 commits into from Jul 4, 2019

Conversation

@Mte90
Copy link
Contributor

commented Jul 4, 2019

No description provided.

@Mte90 Mte90 added the enhancement label Jul 4, 2019

@Mte90 Mte90 requested a review from tomjn Jul 4, 2019

@Mte90 Mte90 self-assigned this Jul 4, 2019

@tomjn
Copy link
Member

left a comment

We'll need to check if the token file is already there so it doesn't break things for existing users, and document it. There'll also need to be a changelog update

@tomjn

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

hmm actually no, it needs documenting and changelog'ing but no need to check if the file exists

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Added the changelog and for documenting I am working on that

@Mte90

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@tomjn

tomjn approved these changes Jul 4, 2019

@tomjn tomjn merged commit 26bfaf0 into Varying-Vagrant-Vagrants:develop Jul 4, 2019

@Mte90 Mte90 deleted the Mte90:github-token-config branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.