Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML validation, fix #1745 #1923

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@Mte90
Copy link
Contributor

Mte90 commented Aug 9, 2019

This code add an exception in case the yaml file is wrong with an alert.
Also a check if sistes is defined or not.

I am looking for other stuff to check :-)

PS: seems that my editor removed all the useless whitespaces

@Mte90 Mte90 requested a review from tomjn Aug 9, 2019
@Mte90 Mte90 referenced this pull request Aug 9, 2019
@tomjn
tomjn approved these changes Aug 9, 2019
Copy link
Member

tomjn left a comment

This looks good enough, though we could do with some screenshots for twitter and a copy paste of what the exception might look like for the release post

@Mte90 Mte90 marked this pull request as ready for review Aug 9, 2019
@Mte90

This comment has been minimized.

Copy link
Contributor Author

Mte90 commented Aug 9, 2019

Screenshot_20190809_162103
This is the screen and the approval is for you :-D

@Mte90 Mte90 merged commit e0a3e45 into Varying-Vagrant-Vagrants:develop Aug 14, 2019
@Mte90 Mte90 deleted the Mte90:yaml-1745 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.