From 057da974c6c0ed028ee241adea7ec1893ad314c9 Mon Sep 17 00:00:00 2001 From: Matias Saggiorato Date: Thu, 22 Oct 2020 21:04:46 -0300 Subject: [PATCH 1/3] Create /vvv folder (and we'll depecrate /vagrant in favor of this later) --- provision/provision.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/provision/provision.sh b/provision/provision.sh index 80790d9c3..9736bee2b 100755 --- a/provision/provision.sh +++ b/provision/provision.sh @@ -12,6 +12,7 @@ . "/srv/config/bash_aliases" # cleanup +mkdir -p /vvv mkdir -p /vagrant rm -rf /vagrant/failed_provisioners mkdir -p /vagrant/failed_provisioners From 8affcefec3ab9fb519a15da06653d921a0750f61 Mon Sep 17 00:00:00 2001 From: Matias Saggiorato Date: Thu, 22 Oct 2020 21:05:27 -0300 Subject: [PATCH 2/3] Avoid apt-get update from running multiple times in the same day. --- provision/provision-helpers.sh | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/provision/provision-helpers.sh b/provision/provision-helpers.sh index d0acbcc5f..e3df0c6b0 100644 --- a/provision/provision-helpers.sh +++ b/provision/provision-helpers.sh @@ -10,6 +10,7 @@ export GREEN="\033[38;5;2m" export RED="\033[38;5;9m" export CRESET="\033[0m" export BOLD="\033[1m" +export VVV_APT_GET_EVERY=$((60*60*24)) # every day VVV_CONFIG=/vagrant/vvv-custom.yml if [[ -f /vagrant/config.yml ]]; then @@ -152,6 +153,25 @@ function noroot() { } export -f noroot +function vvv_maybe_run_apt_update() { + curr_date=$(date +%s) + last_apt_update=0 + if [ -f /vvv/apt_update_last_run ]; then + last_apt_update=$(stat -c %Y "/vvv/apt_update_last_run") + fi + diff=$((curr_date-last_apt_update)); + + if [ "$diff" -lt "$VVV_APT_GET_EVERY" ]; then + return + fi + touch /vvv/apt_update_last_run + + echo " * Running apt-get update..." + rm -rf /var/lib/apt/lists/* + apt-get update -y --fix-missing +} +export -f vvv_maybe_run_apt_update + function vvv_apt_keys_has() { local keys=$( apt-key list ) if [[ ! $( echo "${keys}" | grep "$1") ]]; then @@ -280,10 +300,8 @@ vvv_package_install() { echo " * Updating apt keys" apt-key update -y - # Update all of the package references before installing anything - echo " * Running apt-get update..." - rm -rf /var/lib/apt/lists/* - apt-get update -y --fix-missing + # Maybe update all of the package references before installing anything + vvv_maybe_run_apt_update # Install required packages echo " * Installing apt-get packages..." From 975d0f05d07ffeb9e9689d8b9328916add267100 Mon Sep 17 00:00:00 2001 From: Matias Saggiorato Date: Thu, 22 Oct 2020 21:25:30 -0300 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49ebc5130..79f4409aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ permalink: /docs/en-US/changelog/ * Install WP-CLI doctor package ( #2051 ) * Enhanced database backup terminal output ( #2256 ) * Sites with no `hosts` defined will now default to `{sitename}.test` ( #2267 ) +* Avoid `apt-get update` to run on the main provisioner on every provision ( #2272 ) ### Deprecations