Fix Composer version check #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen this for a few versions of VVV that in both Ubuntu 12.04 and 14.04 the below line of code would always evaluate to false, and as such, always install Composer instead of checking for an update: ```bash if [[ -n "$(composer --version | grep -q 'Composer version')" ]]; then ``` I propose using the following, which seems to evaluate more consistently: ```bash if [[ -n "$(composer --version --no-ansi | grep 'Composer version')" ]]; then ```
|
Hi @thewebists, thanks for the pull request! I just had a chance to test this out and it does fix the installing vs updating check in repeat provisions. We're in a transition toward applying the MIT License to the project. (see #346) Can you confirm that you're ok licensing your contribution as MIT? We're good to merge after that. Thanks! |
|
MIT license is fine. Good choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen this for a few versions of VVV that in both Ubuntu 12.04 and 14.04 the below line of code would always evaluate to false, and as such, always install Composer instead of checking for an update:
I propose using the following, which seems to evaluate more consistently: