Fix #1868: Grunt/Webpack output on template-develop in a file #16
Merged
Fix #1868: Grunt/Webpack output on template-develop in a file #16
Conversation
tomjn
requested changes
Oct 14, 2019
Member
tomjn
left a comment
tomjn
left a comment
There was a problem hiding this comment.
Looks good but I'd really like the Grunt initialized part to be replaced by a check on the return value to see if it failed or not, $? will give you the return code of the last command to run
Member
|
Also, where is |
tomjn
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will move the output from the VVV one to a specific file as Varying-Vagrant-Vagrants/VVV#1868.
Require a bit of testing.