Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1868: Grunt/Webpack output on template-develop in a file #16

Merged
merged 5 commits into from Oct 17, 2019

Conversation

@Mte90
Copy link
Member

@Mte90 Mte90 commented Oct 10, 2019

This will move the output from the VVV one to a specific file as Varying-Vagrant-Vagrants/VVV#1868.
Require a bit of testing.

@Mte90 Mte90 requested a review from Oct 10, 2019
Copy link
Member

@tomjn tomjn left a comment

Looks good but I'd really like the Grunt initialized part to be replaced by a check on the return value to see if it failed or not, $? will give you the return code of the last command to run

@tomjn
Copy link
Member

@tomjn tomjn commented Oct 14, 2019

Also, where is NAME defined, and should it not be provisioner-site-...-grunt.log

tomjn
tomjn approved these changes Oct 17, 2019
@tomjn tomjn merged commit a596d82 into master Oct 17, 2019
@Mte90 Mte90 deleted the mte90/fix-1868 branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants