Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashes in db_name #18

Merged

Conversation

@msaggiorato
Copy link
Member

@msaggiorato msaggiorato commented Oct 1, 2019

This allow dashes to be used in the db_name

Mte90
Mte90 approved these changes Oct 1, 2019
Copy link
Member

@tomjn tomjn left a comment

There's a lot of stuff in searches about - being a non-standard character and requiring special escaping. I see this PR adds the backticks, but the main VVV core will need adjusting too so that the backup and restore scripts still work. I also don't know how this will impact PHP software

@tomjn tomjn merged commit b955095 into Varying-Vagrant-Vagrants:master Oct 2, 2019
@msaggiorato msaggiorato deleted the allow-dashes-on-db-name branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants