Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect attachments not found locally to an external domain. #24

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@msaggiorato
Copy link
Member

@msaggiorato msaggiorato commented Oct 2, 2019

This is a rework of the code proposed in the PR #5 (which I had working for a while already)

This supports multisites with subdirectory setups to properly handle the uploads.

This is a rework of the code proposed in the PR Varying-Vagrant-Vagrants#5 (which I had working for a while already)

This supports multisites with subdirectory setups to properly handle the uploads.
tomjn
tomjn approved these changes Oct 4, 2019
@tomjn
Copy link
Member

@tomjn tomjn commented Oct 4, 2019

I think a good next step would be to eliminate all these various placeholder variables that act as substitutions, and replace them with more generic {{VVV_BEFORE_WP_RULES}} and {{VVV_AFTER_WP_RULES}} or something to that effect, so that users don't have to start adding new bits to configs on every update to get the new features

@tomjn tomjn merged commit 133c3cb into Varying-Vagrant-Vagrants:master Oct 4, 2019
@msaggiorato msaggiorato deleted the live-url-support branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants