Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set strict script execution for site provisioners #27

Merged
merged 2 commits into from Oct 18, 2019
Merged

Conversation

@tomjn
Copy link
Member

@tomjn tomjn commented Oct 17, 2019

Sets the script for stricter provisioning, see this article for details on what these options mean and why.

With this change, failures in this site provisioner will allow the main site provisioner to detect failure.

Note that this will need extensive testing

@Mte90
Copy link
Member

@Mte90 Mte90 commented Oct 18, 2019

I get only on error on line https://github.com/Varying-Vagrant-Vagrants/custom-site-template/blob/master/provision/vvv-init.sh#L34

/tmp/vagrant-shell: line 34: $2: unbound variable
We a lot of variable not referenced in the various provisioner so we will get a lot of errors reported for a non-issue.

GitHub
For when you just need a simple dev site. Contribute to Varying-Vagrant-Vagrants/custom-site-template development by creating an account on GitHub.

@tomjn
Copy link
Member Author

@tomjn tomjn commented Oct 18, 2019

@Mte90 it's complaining about the user of ${VVV_PATH_TO_SITE}? hmmm

@Mte90
Copy link
Member

@Mte90 Mte90 commented Oct 18, 2019

Yes because the u parameter alert about the variable not defined in the script.

@tomjn
Copy link
Member Author

@tomjn tomjn commented Oct 18, 2019

@Mte90 I've removed the u for now, but it surprises me that it throws an error at that point for that variable and not earlier

Mte90
Mte90 approved these changes Oct 18, 2019
Copy link
Member

@Mte90 Mte90 left a comment

Tested :-)

@Mte90 Mte90 merged commit 7448fb5 into master Oct 18, 2019
@Mte90 Mte90 deleted the modify/strictmachine branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants