Skip to content

Set strict script execution for site provisioners#27

Merged
Mte90 merged 2 commits into
masterfrom
modify/strictmachine
Oct 18, 2019
Merged

Set strict script execution for site provisioners#27
Mte90 merged 2 commits into
masterfrom
modify/strictmachine

Conversation

@tomjn

@tomjn tomjn commented Oct 17, 2019

Copy link
Copy Markdown
Member

Sets the script for stricter provisioning, see this article for details on what these options mean and why.

With this change, failures in this site provisioner will allow the main site provisioner to detect failure.

Note that this will need extensive testing

@tomjn tomjn requested a review from a team October 17, 2019 21:48
@Mte90

Mte90 commented Oct 18, 2019

Copy link
Copy Markdown
Member

I get only on error on line https://github.com/Varying-Vagrant-Vagrants/custom-site-template/blob/master/provision/vvv-init.sh#L34

/tmp/vagrant-shell: line 34: $2: unbound variable
We a lot of variable not referenced in the various provisioner so we will get a lot of errors reported for a non-issue.

GitHub
For when you just need a simple dev site. Contribute to Varying-Vagrant-Vagrants/custom-site-template development by creating an account on GitHub.

@tomjn

tomjn commented Oct 18, 2019

Copy link
Copy Markdown
Member Author

@Mte90 it's complaining about the user of ${VVV_PATH_TO_SITE}? hmmm

@Mte90

Mte90 commented Oct 18, 2019

Copy link
Copy Markdown
Member

Yes because the u parameter alert about the variable not defined in the script.

@tomjn

tomjn commented Oct 18, 2019

Copy link
Copy Markdown
Member Author

@Mte90 I've removed the u for now, but it surprises me that it throws an error at that point for that variable and not earlier

@Mte90 Mte90 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested :-)

@Mte90 Mte90 merged commit 7448fb5 into master Oct 18, 2019
@Mte90 Mte90 deleted the modify/strictmachine branch October 18, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants