Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2031 #35

Open
wants to merge 8 commits into
base: master
from
Open

Fix #2031 #35

wants to merge 8 commits into from

Conversation

@Mte90
Copy link
Contributor

Mte90 commented Dec 27, 2019

Ref: Varying-Vagrant-Vagrants/VVV#2031

This fix the issue that constants are not added and now handle boolean/strings values in WP-CLI.

Mte90 added 4 commits Dec 27, 2019
@@ -159,11 +159,16 @@ else
sed -i "s#{{LIVE_URL}}##" "${VVV_PATH_TO_SITE}/provision/vvv-nginx.conf"
fi
get_config_value 'wpconfig_constants' |
shyaml get-values-0 "sites.${VVV_SITE_NAME}.custom.wpconfig_constants" < "${VVV_CONFIG}" |

This comment has been minimized.

Copy link
@tomjn

tomjn Dec 27, 2019

Member

Is there no get_config_values?

This comment has been minimized.

Copy link
@Mte90
Mte90 added 4 commits Dec 29, 2019
@Mte90 Mte90 requested a review from tomjn Jan 12, 2020
@Mte90

This comment has been minimized.

Copy link
Contributor Author

Mte90 commented Jan 12, 2020

The user reported in the issue that works and also on my tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.