Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WpCli-dev utilities #35

Merged
merged 7 commits into from
Nov 1, 2019
Merged

Add WpCli-dev utilities #35

merged 7 commits into from
Nov 1, 2019

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Oct 10, 2019

This utility can be used to contribute to WP-CLI but also to use the dev version.

It will create a new command, wp-dev, and a new folder in the www folder so in this way it is possible to access to the code.

It is based on https://github.com/Mte90/template-wp-cli-develop

@Mte90 Mte90 marked this pull request as ready for review October 10, 2019 12:57
@Mte90
Copy link
Member Author

Mte90 commented Oct 10, 2019

Tested, it is working!
Also unit tests works :-D

Screenshot_20191010_145950

We only need to do docs about it

Copy link
Member

@tomjn tomjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more output statements so we know what the provisioner is doing in the logs. We also need statements announcing it's started, and that it's finished

wpcli-dev/provision.sh Outdated Show resolved Hide resolved
wpcli-dev/provision.sh Show resolved Hide resolved
@Mte90 Mte90 requested a review from tomjn October 21, 2019 16:32
Mte90 added a commit to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org that referenced this pull request Oct 28, 2019
wpcli-dev/provision.sh Outdated Show resolved Hide resolved
wpcli-dev/provision.sh Show resolved Hide resolved
tomjn pushed a commit to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org that referenced this pull request Oct 31, 2019
Co-Authored-By: Tom J Nowell <contact@tomjn.com>
@Mte90 Mte90 requested a review from tomjn October 31, 2019 15:52
@tomjn tomjn merged commit 7c8fb2c into Varying-Vagrant-Vagrants:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants