Adjust the syntax of if statements calling the is_utility_installed script#2073
Merged
Mte90 merged 3 commits intoVarying-Vagrant-Vagrants:developfrom Feb 14, 2020
h4r1m4u:develop
Merged
Adjust the syntax of if statements calling the is_utility_installed script#2073Mte90 merged 3 commits intoVarying-Vagrant-Vagrants:developfrom h4r1m4u:develop
Mte90 merged 3 commits intoVarying-Vagrant-Vagrants:developfrom
h4r1m4u:develop
Conversation
Member
|
I will test it tomorrow, probably we will have to do some changes also on the vv-utilities repo :-) |
Mte90
approved these changes
Feb 14, 2020
Member
Mte90
left a comment
Mte90
left a comment
There was a problem hiding this comment.
I tested and can confirm that without that patch the certificate is not define at all inside nginx files
Member
|
Thanks for the help, if you are interested on contributing more also on testing we are on our slack instance https://varyingvagrantvagrants.org/docs/en-US/slack/
|
Contributor
Author
|
@Mte90 Awesome, thanks very much, Daniele. I'm glad I could help. I'll check out the Slack group too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses problem with SSL certificates not being correctly added into Nginx site configs described in issue #2072.
Checks
developbranch not themasterbranch.