Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always force the root password to its documented default #2077

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Always force the root password to its documented default #2077

merged 4 commits into from
Feb 25, 2020

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Feb 25, 2020 •
edited
Loading

Summary:

Always force the root password to its documented default on provision, fixes #2076, and force copies a MySQL config in case updates need to be made in the future

Checks

  • I've tested this PR with Vagrant vXX and VirtualBox vXX on Operating System
  • This PR is for the develop branch not the master branch.
  • I've updated the changelog.
  • This PR is complete and ready for review.

@tomjn tomjn added the type:bug label Feb 25, 2020
@update-docs
Copy link

update-docs bot commented Feb 25, 2020 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionaly any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn requested a review from a team February 25, 2020 12:39
Mte90
Mte90 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@Mte90 Mte90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@Mte90 Mte90 merged commit 106a62d into develop Feb 25, 2020
@Mte90 Mte90 deleted the fix/2076 branch February 25, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mte90 Mte90 Mte90 approved these changes

Assignees
No one assigned
Labels
provisioner:core type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure root user has the default credentials in MariaDB
2 participants
@tomjn @Mte90