Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace expired vmware_workstation provider and add other providers to default-config.yml #2091

Merged
merged 4 commits into from Mar 22, 2020

Conversation

bc1121
Copy link
Contributor

@bc1121 bc1121 commented Mar 21, 2020

Summary:

vmware_workstation is broken as a provider. It needs to be replaced as an example in the default-config.yml file. vmware_desktop correctly loads the latest bento box on VMWare Workstation and VMWare Fusion and is platform agnostic.

vmware_desktop brings the provider in line with the current VVV Vagrantfile and the labels on the bento box used by all of the alt providers: https://app.vagrantup.com/bento/boxes/ubuntu-18.04

The other providers are added as a convenience for hyperv and parallels users and virtualbox just to complete the list of optional providers even though currently it would only override itself.

I realize this is virtually identical to the previous pull request but take your pick: The first one corrects only the provider currently listed there. This is more convenient for all alt provider users. Hopefully growing more relevant as Vagrant grows more provider agnostic.

Checks

  • [ x] I've tested this PR with Vagrant 2.2.7 and VirtualBox on Operating System
  • [ x] This PR is for the develop branch not the master branch.
  • [x ] I've updated the changelog.
  • [x ] This PR is complete and ready for review.

@update-docs
Copy link

update-docs bot commented Mar 21, 2020

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionaly any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

tomjn
tomjn approved these changes Mar 22, 2020
Copy link
Member

@tomjn tomjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomjn tomjn merged commit 6ff25ad into Varying-Vagrant-Vagrants:develop Mar 22, 2020
@welcome
Copy link

welcome bot commented Mar 22, 2020

Congrats on merging your first pull request!

@tomjn tomjn added this to the 3.3 milestone Mar 22, 2020
@tomjn tomjn modified the milestones: 3.3, 3.4 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants