Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor network checks #2099

Merged
merged 3 commits into from
Apr 5, 2020
Merged

Refactor network checks #2099

merged 3 commits into from
Apr 5, 2020

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Apr 5, 2020

Summary:

Refactor how network connections are checked to check more domains and update text

Screenshot 2020-04-05 at 14 58 55

Checks

  • I've tested this PR with Vagrant v2.2.7 and VirtualBox v6.1 on MacOS
  • This PR is for the develop branch not the master branch.
  • I've updated the changelog.
  • This PR is complete and ready for review.

@update-docs
Copy link

update-docs bot commented Apr 5, 2020

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionaly any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn added this to the 3.3 milestone Apr 5, 2020
@tomjn tomjn merged commit 53b0397 into develop Apr 5, 2020
@Mte90
Copy link
Member

Mte90 commented Apr 8, 2020

I had time now to test the last changes and there is a typo "Succesful" also in the screenshot of this pr

@tomjn tomjn modified the milestones: 3.3, 3.4 Apr 14, 2020
@Mte90 Mte90 deleted the tomjn/network-checks branch May 6, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants