Skip to content

Fix failure bear not working properly. - #2108

Merged
tomjn merged 1 commit into
Varying-Vagrant-Vagrants:developfrom
saucal:feature/fix-failure-bear
Apr 9, 2020
Merged

Fix failure bear not working properly.#2108
tomjn merged 1 commit into
Varying-Vagrant-Vagrants:developfrom
saucal:feature/fix-failure-bear

Conversation

@msaggiorato

Copy link
Copy Markdown
Member

I did a clean provision, no errors on any logs. SSHd in and there was nothing on /vagrant/failed_provisioners.

So i noticed that we needed to use the -z flag to check if the ls is empty or not.

@update-docs

update-docs Bot commented Apr 9, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionaly any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@msaggiorato
msaggiorato requested review from a team and tomjn April 9, 2020 15:44

@tomjn tomjn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tomjn
tomjn merged commit b760407 into Varying-Vagrant-Vagrants:develop Apr 9, 2020
@msaggiorato
msaggiorato deleted the feature/fix-failure-bear branch April 9, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants