Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure bear not working properly. #2108

Merged

Conversation

msaggiorato
Copy link
Member

I did a clean provision, no errors on any logs. SSHd in and there was nothing on /vagrant/failed_provisioners.

So i noticed that we needed to use the -z flag to check if the ls is empty or not.

@update-docs
Copy link

update-docs bot commented Apr 9, 2020

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionaly any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@msaggiorato msaggiorato requested review from tomjn and a team April 9, 2020 15:44
tomjn
tomjn approved these changes Apr 9, 2020
Copy link
Member

@tomjn tomjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tomjn tomjn merged commit b760407 into Varying-Vagrant-Vagrants:develop Apr 9, 2020
@msaggiorato msaggiorato deleted the feature/fix-failure-bear branch April 9, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants