Skip to content

Switch to vagrant-hostmanager#2112

Merged
tomjn merged 4 commits intodevelopfrom
add/hostsmanager
Apr 25, 2020
Merged

Switch to vagrant-hostmanager#2112
tomjn merged 4 commits intodevelopfrom
add/hostsmanager

Conversation

@tomjn
Copy link
Member

@tomjn tomjn commented Apr 10, 2020

Summary:

hostsupdater sets our host files on the host OS, but the status of that project is unknown. It looks like the owner might have gone AWOL, and there are Windows issues sitting unfixed, PR's unreviewed, etc.

Given we have Windows users with issues ( see #2026 ), we should look into an alternative, this PR tries to swap hostsupdater for hostmanager, with a fallback to the original.

If you have both installed, hostsupdater will still try to add the vvv domain to the hosts file, I could find no way to eliminate this.

PR is currently working locally on an existing VM in MacOS with Virtualbox:

Screenshot 2020-04-10 at 10 50 21

I'd like to see the results of testing this PR on Windows and Linux, in particular from those users with issues

Checks

  • [xv] I've tested this PR with Vagrant v2.2.7 and VirtualBox v6.0.14 on MacOS
  • This PR is for the develop branch not the master branch.
  • I've updated the changelog.
  • This PR is complete and ready for review.

@update-docs
Copy link

update-docs bot commented Apr 10, 2020

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionaly any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@Mte90
Copy link
Member

Mte90 commented Apr 10, 2020

I will test it but maybe a ticket to track that we need to update the doc and cd usb generator so we don't forget to do it.

Mte90
Mte90 previously approved these changes Apr 10, 2020
Copy link
Member

@Mte90 Mte90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux and everything works as should with this plugin installed.
Maybe we should prompt an alert if the os is Windows and using the old plugin?

@tomjn
Copy link
Member Author

tomjn commented Apr 10, 2020

The main point of this is to improve things for Windows, we need to confirm that's the case

@Mte90 Mte90 requested a review from a user April 14, 2020 09:54
@Mte90
Copy link
Member

Mte90 commented Apr 14, 2020

@benlumia007 can you test this pr on windows?

@ghost
Copy link

ghost commented Apr 16, 2020

i was gonna say

config.hostmanager.include_offline = false

because if you destroy the box, the previous hosts are still available. unelss u guys wanted to set it to true.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks fine if the offline is meant to be true.

@tomjn tomjn merged commit 99df8a2 into develop Apr 25, 2020
@ghost
Copy link

ghost commented Apr 26, 2020

please note after doing some more test, if you do vagrant reload --provision if u have a new site that u added after the first vagrant up. it won't update the hosts file.

the plugin for vagrant-hostmanager only hooks to vagrant up and vagrant destroy.

@Mte90 Mte90 deleted the add/hostsmanager branch May 11, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants