Conversation
|
Thanks for opening this pull request! Make sure
|
|
I will test it but maybe a ticket to track that we need to update the doc and cd usb generator so we don't forget to do it. |
Mte90
left a comment
There was a problem hiding this comment.
Tested on Linux and everything works as should with this plugin installed.
Maybe we should prompt an alert if the os is Windows and using the old plugin?
|
The main point of this is to improve things for Windows, we need to confirm that's the case |
|
@benlumia007 can you test this pr on windows? |
|
i was gonna say because if you destroy the box, the previous hosts are still available. unelss u guys wanted to set it to true. |
ghost
left a comment
There was a problem hiding this comment.
it looks fine if the offline is meant to be true.
|
please note after doing some more test, if you do vagrant reload --provision if u have a new site that u added after the first vagrant up. it won't update the hosts file. the plugin for vagrant-hostmanager only hooks to vagrant up and vagrant destroy. |
Summary:
hostsupdater sets our host files on the host OS, but the status of that project is unknown. It looks like the owner might have gone AWOL, and there are Windows issues sitting unfixed, PR's unreviewed, etc.
Given we have Windows users with issues ( see #2026 ), we should look into an alternative, this PR tries to swap hostsupdater for hostmanager, with a fallback to the original.
If you have both installed, hostsupdater will still try to add the
vvvdomain to the hosts file, I could find no way to eliminate this.PR is currently working locally on an existing VM in MacOS with Virtualbox:
I'd like to see the results of testing this PR on Windows and Linux, in particular from those users with issues
Checks
developbranch not themasterbranch.