Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gem binaries to Path if the folder exists #2138

Merged
merged 1 commit into from May 1, 2020

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Apr 26, 2020

Without this, binaries for installed gems aren't available in path

Checks

  • I've tested this PR with Vagrant vXX and VirtualBox vXX on Operating System
  • This PR is for the develop branch not the master branch.
  • I've updated the changelog.
  • This PR is complete and ready for review.

Without this, binaries for installed gems aren't available in path
@update-docs
Copy link

update-docs bot commented Apr 26, 2020

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@Mte90
Copy link
Member

Mte90 commented May 1, 2020

Any idea how to test it?
I think that we need to install ruby and gem right?

@tomjn
Copy link
Member Author

tomjn commented May 1, 2020

correct, you need to install ruby via snap/linuxbrew, then install a gem, and check it's on PATH

@msaggiorato
Copy link
Member

Shouldn't this be handled somewhere else? Or have a way to allow utilities to hook on the PATH? Like extra files loaded alongside this on a specific path that utilities can append files to? Similar to how a lot of configurations work in linux, or how the MOTD files are loaded.

That way we can have priorities so that some things happen before others. Seems like an overkill just for this tho, but it would be a nice extensibility option for utilities.

@tomjn
Copy link
Member Author

tomjn commented May 1, 2020

If we add the ability to install ruby gems from the config.yml file in the core provisioner, it won't be useful if none of those gems are in PATH, this is a pre-requisite for #2135

@msaggiorato
Copy link
Member

Oh I see.

But shouldn't we add something to the provisioner to install ruby alongside this? Just to review the feature as a whole I mean.

@tomjn
Copy link
Member Author

tomjn commented May 1, 2020

Only if ruby gems are specified, which means it has to be a part of the PR that implements that issue.

But in the meantime, people using wordmove and other gems have to manually install only to find that the binaries aren't in PATH, even if they manually install ruby themselves. So adding it to the bash profile saves them having to fork VVV to get ruby gems working

Copy link
Member

@msaggiorato msaggiorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then i guess this works as a workaround for the time being.

@tomjn tomjn merged commit c22a1bc into develop May 1, 2020
1 check passed
@Mte90 Mte90 deleted the add/ruby-gem-binary-path branch May 11, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants