New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gem binaries to Path if the folder exists #2138
Conversation
Without this, binaries for installed gems aren't available in path
Thanks for opening this pull request! Make sure
|
Any idea how to test it? |
correct, you need to install ruby via snap/linuxbrew, then install a gem, and check it's on PATH |
Shouldn't this be handled somewhere else? Or have a way to allow utilities to hook on the PATH? Like extra files loaded alongside this on a specific path that utilities can append files to? Similar to how a lot of configurations work in linux, or how the MOTD files are loaded. That way we can have priorities so that some things happen before others. Seems like an overkill just for this tho, but it would be a nice extensibility option for utilities. |
If we add the ability to install ruby gems from the |
Oh I see. But shouldn't we add something to the provisioner to install ruby alongside this? Just to review the feature as a whole I mean. |
Only if ruby gems are specified, which means it has to be a part of the PR that implements that issue. But in the meantime, people using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then i guess this works as a workaround for the time being.
Without this, binaries for installed gems aren't available in path
Checks
develop
branch not themaster
branch.