Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid oh noes issues and add extra info to it #2161

Merged
merged 8 commits into from
May 25, 2020

Conversation

msaggiorato
Copy link
Member

Fixes #2159

@update-docs
Copy link

update-docs bot commented May 21, 2020

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@msaggiorato msaggiorato marked this pull request as ready for review May 21, 2020 19:30
config/homebin/vagrant_up Outdated Show resolved Hide resolved
@Mte90 Mte90 requested a review from tomjn May 22, 2020 17:17
CHANGELOG.md Outdated Show resolved Hide resolved
config/homebin/vagrant_up Outdated Show resolved Hide resolved
config/homebin/vagrant_up Outdated Show resolved Hide resolved
Copy link
Member

@tomjn tomjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions

tomjn
tomjn previously approved these changes May 25, 2020
msaggiorato and others added 8 commits May 25, 2020 11:31
If this is not done, failed site or utility provisioners which are disabled, are still reported as failed provisioners even if they're not run anymore.

Caveat here, is that if the main provisioner doesn't run again, then that error doesn't disapear.
Co-authored-by: Tom J Nowell <contact@tomjn.com>
Co-authored-by: Tom J Nowell <contact@tomjn.com>
Co-authored-by: Tom J Nowell <contact@tomjn.com>
@tomjn tomjn merged commit a978322 into Varying-Vagrant-Vagrants:develop May 25, 2020
@msaggiorato msaggiorato deleted the fix/oh-noes branch May 25, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarting Nginx and MySQL – oh noes :'( Provisioning incomplete!
3 participants