Fix invalid oh noes issues and add extra info to it#2161
Merged
tomjn merged 8 commits intoVarying-Vagrant-Vagrants:developfrom May 25, 2020
Merged
Fix invalid oh noes issues and add extra info to it#2161tomjn merged 8 commits intoVarying-Vagrant-Vagrants:developfrom
tomjn merged 8 commits intoVarying-Vagrant-Vagrants:developfrom
Conversation
|
Thanks for opening this pull request! Make sure
|
Mte90
reviewed
May 22, 2020
tomjn
reviewed
May 23, 2020
tomjn
reviewed
May 23, 2020
tomjn
reviewed
May 23, 2020
tomjn
previously approved these changes
May 25, 2020
If this is not done, failed site or utility provisioners which are disabled, are still reported as failed provisioners even if they're not run anymore. Caveat here, is that if the main provisioner doesn't run again, then that error doesn't disapear.
Co-authored-by: Tom J Nowell <contact@tomjn.com>
Co-authored-by: Tom J Nowell <contact@tomjn.com>
Co-authored-by: Tom J Nowell <contact@tomjn.com>
tomjn
approved these changes
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2159