UI Improvements #445

connyduck · 2017-11-10T10:08:29Z

In this branch I will experiment with some ui stuff. Feedback welcome!

connyduck · 2017-11-10T11:06:57Z

Do people like the SparkButtons? I don't. The animation always gets cut off, is not antialiased and annoying imho.

…area

connyduck · 2017-11-10T12:02:15Z

Before:

Changes so far:

imho looks much better

charlag · 2017-11-10T12:04:41Z

@connyduck I kinda liked them at first but grew tired with time. It could be okay if they were faster, smaller and worked correctly (but they glich sometimes for me). I didn't experience any anti-aliasing or cutting problems for a long time, though. I am not sure how people will react but if there will be another kind of a callback it is fine.

charlag · 2017-11-10T12:05:42Z

Nice job, by the way, looks tidy!

charlag · 2017-11-10T12:07:39Z

I would get rid of the links underline too.

connyduck · 2017-11-10T12:53:12Z

Great idea!
Next step: improving notifications the same way and polishing the detail status.

charlag · 2017-11-10T14:32:00Z

Awesome!

charlag · 2017-11-10T14:53:27Z

If we're already here... Do you like horizontal animations for opening activities? I don't like them much. They would also look weird with shared elements transitions which I would like to add at some point.

Also, I still forget to focus on field automatically in search. What do you think about it?

connyduck · 2017-11-10T16:08:10Z

Well the activity animations don't really bother me personally but I heard it from other people as well that they should be removed.
And yes, the search field should focus automatically. This should be an easy fix.

connyduck · 2017-11-11T12:37:48Z

New detail statuses!
Before:

After:

Still missing: number of boosts/favs in the same colour as the icon, no boosts number when private.

charlag · 2017-11-11T12:40:11Z

Awesome thank you!
I see a small problem on the picture - there's no bottom line on the expanded status.

charlag · 2017-11-11T12:40:26Z

Or is it intended?

connyduck · 2017-11-11T12:43:11Z

I am not sure what you mean exactly? Everything is intended, the thread line would have crossed the text.

charlag · 2017-11-11T12:45:11Z

Yes, you're right, my apologies. I checked and Twitter works pretty much the same way

connyduck · 2017-11-17T19:24:08Z

So now notifications are improved as well :)

Before:

After:

charlag · 2017-11-18T05:24:17Z

Wow, this looks awesome! Thank you.

connyduck · 2017-11-20T13:58:50Z

Less views in layouts -> more performance ✨

charlag

Why inefficient RelativeLayout when there's more powerful and performant ConstraintLayout?
(BTW thanks a lot for these improvements 🙇

…g on a toot

…1y text size option

connyduck · 2017-11-27T19:21:38Z

So this is now mostly done. Should fix #117 #446 #192 and partly #429
The only thing missing is that MediaActivity still behaves strange, if a post has gifs&plain images attached.
Using Glide instead of Picasso is NOT a solution, since mastodon "gifs" are in fact mp4s.

I will have another look if I find a better spark button library

connyduck · 2017-11-28T21:54:21Z

So I decided that Tusky 1.4.0 should be released asap, main reason is that crash rate in play console is really high. Please review this pull request, it contains at least one fix for a crash (should have made it a separate commit). @charlag

charlag · 2017-11-29T07:12:52Z

Will do! It's not too late, right?

charlag · 2017-11-29T07:35:22Z

app/src/main/res/layout/item_status.xml

@@ -318,14 +322,12 @@

        <com.varunest.sparkbutton.SparkButton
            android:id="@+id/status_reblog"
-            android:layout_width="40dp"


I thought you would keep button size the same and only make icon inside it smaller. It is okay for me, just worrying for people who claim themselves clumsy.

charlag · 2017-11-29T07:48:12Z

app/src/main/java/com/keylesspalace/tusky/TuskyApplication.java

@@ -39,6 +39,7 @@ public void onCreate() {
        Picasso.Builder builder = new Picasso.Builder(this);
        builder.downloader(new OkHttp3Downloader(OkHttpUtils.getCompatibleClient()));
        if (BuildConfig.DEBUG) {
+            builder.loggingEnabled(true);


https://square.github.io/picasso/2.x/picasso/com/squareup/picasso/Picasso.Builder.html#loggingEnabled-boolean-

"WARNING: Enabling this will result in excessive object allocation. This should be only be used for debugging purposes. Do NOT pass BuildConfig.DEBUG."

Ah, you already removed it, sorry

charlag · 2017-11-29T07:57:14Z

app/src/main/java/com/keylesspalace/tusky/adapter/NotificationsAdapter.java

            if (!shouldShowContentIfSpoiler && hasSpoiler) {
-                if (statusViewData.getMentions() != null &&


Sorry, but I don't understand why you undid this. I've tried to match web version, there's even an issue somewhere asking for this behavior. Please, consider using this for the rest of the app.

Ok, but why was it only done for notifications? I found it highly confusing that in notifications mentions are outside spoiler, but not in normal toots

Yes, it was only done for notifications because I didn't have time to change it everywhere.

charlag · 2017-11-29T08:02:08Z

I am not sure if it's a bug or intended behavior but when I click on the notification text it doesn't get me anywhere. I have to aim at the empty space.

charlag · 2017-11-29T08:08:21Z

There's no more "delete" button in the timeline, only in the detailed view. When I tried to delete my status from there it didn't disappear from the timeline (it was on the top).

charlag · 2017-11-29T16:59:06Z

I think that font is statuses is a little bit too bit. I would do -1 sp or something.
Also font in detailed status is smaller than in the regular one?

connyduck · 2017-11-29T20:00:12Z

I will fix the notification click area, thx for noticing.

Afaik there never was a delete button in the timeline (at least not since I am maintainer). This should be consistent, yes, but I will make a seperate issue for it. (EDIT: Can't reproduce it right now o_0) That the status does not disappear is a bug that we also have for a long time.

Well Material design recommended size for regular text is 16sp. I am now using the 15sp for some days and I really love it. I think we should add a option to change the font-size between 12-18.
I am not sure, I believe font size in detailed status only looks smaller, but is actually the same size, but will check again.

charlag · 2017-11-30T04:50:27Z

Oh, sorry, my memory ia not really great and can give me false memories.
I've checked detailed and it looks the same, my bad.

connyduck added 4 commits November 10, 2017 10:48

smaller icon for reblogged bar

06271ca

replace LinearLayout and ImageView with CompoundDrawable

95b37f0

show reply all icon when status is a reply

64d4400

use empty star for inactive favourite icon

81fddf9

connyduck added 3 commits November 10, 2017 12:12

improve toot action buttons - smaller, click indicator, better click …

3b64cf3

…area

increase line height of statuses 10%

0345859

evenly space avatar in status

0aca511

remove underlines from links in statuses

00d73d5

improve detail statuses

b5eb1db

connyduck added 4 commits November 13, 2017 21:57

open keyboard once SearchActivity is visible

8f293cd

fix bug where not all mentions were stripped of underline

d088ebe

simplify item_status.xml layout

80f31c4

improve notification layout

98f872b

add custom emojis to spoiler warnings

81ec1c3

charlag reviewed Nov 20, 2017

View reviewed changes

connyduck added 5 commits November 21, 2017 18:32

make tabs in AccountActivity fill whole width in landscape mode

b5d5317

fix color of thread line in light theme

ba3b40d

fix a problem where we used the wrong span when mentions where missin…

dab5057

…g on a toot

set textSize to 15sp and fix problems with text when using Android a1…

721b91a

…1y text size option

set textSize to 15sp and fix problems with text when using Android a1…

4849c4c

…1y text size option

connyduck force-pushed the ui-improvements branch from 1688382 to eb39bf9 Compare November 27, 2017 21:13

one play indicator for each media preview, new play indicator design

18d7f5c

connyduck force-pushed the ui-improvements branch from eb39bf9 to 18d7f5c Compare November 28, 2017 06:23

cleanup code

9629351

merge branch master

aa2abcb

charlag reviewed Nov 29, 2017

View reviewed changes

fix notification click area

85cf68e

connyduck changed the title ~~[WIP] UI Improvements~~ UI Improvements Nov 30, 2017

connyduck merged commit 41233a8 into master Nov 30, 2017

connyduck deleted the ui-improvements branch November 30, 2017 19:12

This was referenced Nov 30, 2017

Boosting or favouriting a status with a link preview card makes the card disappear #446

Closed

Posts that have gif & plain images attached are rendered wrong #429

Closed

Toot action buttons are too big #117

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI Improvements #445

UI Improvements #445

connyduck commented Nov 10, 2017

connyduck commented Nov 10, 2017

connyduck commented Nov 10, 2017

charlag commented Nov 10, 2017

charlag commented Nov 10, 2017

charlag commented Nov 10, 2017

connyduck commented Nov 10, 2017

charlag commented Nov 10, 2017

charlag commented Nov 10, 2017

connyduck commented Nov 10, 2017

connyduck commented Nov 11, 2017

charlag commented Nov 11, 2017

charlag commented Nov 11, 2017

connyduck commented Nov 11, 2017

charlag commented Nov 11, 2017

connyduck commented Nov 17, 2017

charlag commented Nov 18, 2017

connyduck commented Nov 20, 2017

charlag left a comment

connyduck commented Nov 27, 2017

connyduck commented Nov 28, 2017

charlag commented Nov 29, 2017

charlag Nov 29, 2017

charlag Nov 29, 2017

charlag Nov 29, 2017

charlag Nov 29, 2017

connyduck Nov 29, 2017

charlag Nov 30, 2017

charlag commented Nov 29, 2017

charlag commented Nov 29, 2017

charlag commented Nov 29, 2017

connyduck commented Nov 29, 2017 •

edited

charlag commented Nov 30, 2017

		if (!shouldShowContentIfSpoiler && hasSpoiler) {
		if (statusViewData.getMentions() != null &&

UI Improvements #445

UI Improvements #445

Conversation

connyduck commented Nov 10, 2017

connyduck commented Nov 10, 2017

connyduck commented Nov 10, 2017

charlag commented Nov 10, 2017

charlag commented Nov 10, 2017

charlag commented Nov 10, 2017

connyduck commented Nov 10, 2017

charlag commented Nov 10, 2017

charlag commented Nov 10, 2017

connyduck commented Nov 10, 2017

connyduck commented Nov 11, 2017

charlag commented Nov 11, 2017

charlag commented Nov 11, 2017

connyduck commented Nov 11, 2017

charlag commented Nov 11, 2017

connyduck commented Nov 17, 2017

charlag commented Nov 18, 2017

connyduck commented Nov 20, 2017

charlag left a comment

Choose a reason for hiding this comment

connyduck commented Nov 27, 2017

connyduck commented Nov 28, 2017

charlag commented Nov 29, 2017

charlag Nov 29, 2017

Choose a reason for hiding this comment

charlag Nov 29, 2017

Choose a reason for hiding this comment

charlag Nov 29, 2017

Choose a reason for hiding this comment

charlag Nov 29, 2017

Choose a reason for hiding this comment

connyduck Nov 29, 2017

Choose a reason for hiding this comment

charlag Nov 30, 2017

Choose a reason for hiding this comment

charlag commented Nov 29, 2017

charlag commented Nov 29, 2017

charlag commented Nov 29, 2017

connyduck commented Nov 29, 2017 • edited

charlag commented Nov 30, 2017

connyduck commented Nov 29, 2017 •

edited