Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main window closes when user cancels External Link warning dialog #3132

Closed
galenbwill opened this issue May 17, 2022 · 0 comments
Closed

Main window closes when user cancels External Link warning dialog #3132

galenbwill opened this issue May 17, 2022 · 0 comments
Assignees
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround

Comments

@galenbwill
Copy link
Contributor

Currently, Binary Ninja will try to close the main window if the user hits cancel on the External Link warning dialog (which appears when a non-local URL is being opened in BN). The flow is like this:

  1. User clicks external binaryninja: URL (or opens a non-local URL via the Open Url action)
  2. User is prompted with a warning dialog about opening an external link
  3. If the user hits Cancel:
  • Currently, BN will call close() on the main window, which will close all open tabs in that window (unless they have unsaved tabs, in which case they will get prompted to save), causing the application to exit if only one window is open.

This is clearly not the right behavior.

So... should BN instead

  1. Only close the window if there are no open files, i.e., the New Tab is the only open tab?
  2. Not attempt to close the window at all?
  3. Maintain current behavior?

For context, I think the original idea was that if the BN application got opened purely in response to an external link, then it would make sense to close BN if the user hits cancel on the warning.

But if BN was already open, does it even make sense to close the window even if no files are open?

@galenbwill galenbwill added Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels May 17, 2022
@galenbwill galenbwill self-assigned this May 17, 2022
@psifertex psifertex added this to the 3.1 (Performance) milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround
Projects
None yet
Development

No branches or pull requests

2 participants