Main window closes when user cancels External Link warning dialog #3132
Labels
Component: UI
Issue needs changes to the user interface
Effort: Trivial
Issue should take < 1 day
Impact: Low
Issue is a papercut or has a good, supported workaround
Milestone
Currently, Binary Ninja will try to close the main window if the user hits cancel on the External Link warning dialog (which appears when a non-local URL is being opened in BN). The flow is like this:
binaryninja:
URL (or opens a non-local URL via the Open Url action)close()
on the main window, which will close all open tabs in that window (unless they have unsaved tabs, in which case they will get prompted to save), causing the application to exit if only one window is open.This is clearly not the right behavior.
So... should BN instead
Maintain current behavior?For context, I think the original idea was that if the BN application got opened purely in response to an external link, then it would make sense to close BN if the user hits cancel on the warning.
But if BN was already open, does it even make sense to close the window even if no files are open?
The text was updated successfully, but these errors were encountered: